ToastRegion: no keyboard way back to a modal dialog after F6

Abierto
  • ¿Algo no está bien?
#10,903 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
accessibility, frontend

Línea de trabajo

Start with the toast region's F6 keyboard handling and its focus management in the react-aria-components toast code, then reproduce the steps with a Modal, a Dialog and a toast containing a button. Focus should return to the element that was focused before F6, and Escape should also restore it, so check that the region tracks that previous element when it is entered from inside a modal. Done means F6, Shift+F6 and Escape from the region all return focus into the dialog, and Tab past the last toast no longer lands on <body>. Expect to need accessibility context and maintainer input on the intended behaviour.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs investigation
Provide a general summary of the issue here

With a modal dialog open, F6 moves focus into the ToastRegion, but no key brings it back to the dialog.

🤔 Expected Behavior?

From the toast region, F6 (or Shift+F6, or Escape) returns focus to the element focused before F6, inside the modal dialog.

😯 Current Behavior
  • F6 moves focus from the dialog to the toast region, as documented.
  • F6 and Shift+F6 keep focus in the region: the rest of the page is inert under the modal, so the region is the only landmark.
  • Escape does nothing.
  • Tab past the last toast puts focus on <body>, outside the dialog.

A keyboard user who checks a toast cannot get back to the dialog, other than by clicking.

💁 Possible Solution

When F6 has moved focus into the toast region from inside a modal, keep the element it came from. F6, Shift+F6 or Escape in the region returns focus there. This is what Base UI's toast viewport does.

🔦 Context

We wrap UNSTABLE_ToastRegion and UNSTABLE_ToastQueue in a design system. Its toasts must stay reachable, and leavable, by keyboard while a dialog is open.

🖥️ Steps to Reproduce
  1. Render a ToastRegion and a DialogTrigger with a Modal and a Dialog that holds a button.
  2. Open the dialog, then add a toast that has a button.
  3. With focus in the dialog, press F6: focus moves to the toast region.
  4. Press F6, then Shift+F6, then Escape: focus stays in the region each time.
  5. Press Tab past the toast's last button: focus lands on <body>.
Version

react-aria-components 1.22.1

What browsers are you seeing the problem on?

Chrome

What operating system are you using?

macOS

Lenguaje dominante
TypeScript
Estrellas
16k
Forks
1.6k
Merge medio
2 d 17 h
PR fusionados (30 d)
41

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de adobe/react-spectrum

Todos los issues de adobe/react-spectrum

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.