ToastRegion: no keyboard way back to a modal dialog after F6

Aperta
  • Qualcosa non va?
#10,903 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, typescript
Ambito
accessibility, frontend

Direzione di ricerca

Start with the toast region's F6 keyboard handling and its focus management in the react-aria-components toast code, then reproduce the steps with a Modal, a Dialog and a toast containing a button. Focus should return to the element that was focused before F6, and Escape should also restore it, so check that the region tracks that previous element when it is entered from inside a modal. Done means F6, Shift+F6 and Escape from the region all return focus into the dialog, and Tab past the last toast no longer lands on <body>. Expect to need accessibility context and maintainer input on the intended behaviour.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs investigation
Provide a general summary of the issue here

With a modal dialog open, F6 moves focus into the ToastRegion, but no key brings it back to the dialog.

🤔 Expected Behavior?

From the toast region, F6 (or Shift+F6, or Escape) returns focus to the element focused before F6, inside the modal dialog.

😯 Current Behavior
  • F6 moves focus from the dialog to the toast region, as documented.
  • F6 and Shift+F6 keep focus in the region: the rest of the page is inert under the modal, so the region is the only landmark.
  • Escape does nothing.
  • Tab past the last toast puts focus on <body>, outside the dialog.

A keyboard user who checks a toast cannot get back to the dialog, other than by clicking.

💁 Possible Solution

When F6 has moved focus into the toast region from inside a modal, keep the element it came from. F6, Shift+F6 or Escape in the region returns focus there. This is what Base UI's toast viewport does.

🔦 Context

We wrap UNSTABLE_ToastRegion and UNSTABLE_ToastQueue in a design system. Its toasts must stay reachable, and leavable, by keyboard while a dialog is open.

🖥️ Steps to Reproduce
  1. Render a ToastRegion and a DialogTrigger with a Modal and a Dialog that holds a button.
  2. Open the dialog, then add a toast that has a button.
  3. With focus in the dialog, press F6: focus moves to the toast region.
  4. Press F6, then Shift+F6, then Escape: focus stays in the region each time.
  5. Press Tab past the toast's last button: focus lands on <body>.
Version

react-aria-components 1.22.1

What browsers are you seeing the problem on?

Chrome

What operating system are you using?

macOS

Lingua principale
TypeScript
Stelle
16k
Fork
1.6k
Merge medio
3g 19h
PR unite (30g)
46

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di adobe/react-spectrum

Tutte le issue di adobe/react-spectrum

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.