Sound effects toggle does nothing: no audio files are in the repository

Abierto
  • ¿Algo no está bien?
#28 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript
Área
frontend

Línea de trabajo

Start with js/config.js and js/utils.js to trace the configured sound paths and playSound, then inspect index.html and the game-end handling. Check the existing README and roadmap claims against the shipped behavior. Done means the sound toggle works for all listed events or is hidden, and the README and roadmap accurately describe the result.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug good first issue severity: low

Summary

The settings panel has a "Sound effects" toggle and the README lists sound as a feature, but assets/sounds/ does not exist. Turning the toggle on gives no sound and one failed request per move.

Where

  • js/config.js:38-45 (CONFIG.ASSETS.SOUNDS paths)
  • js/utils.js:184-193 (playSound, failure only logged)
  • index.html:50-56 (the toggle)
  • README.md:89, README.md:106, README.md:164 (feature claims); README.md:295 and CHANGELOG.md:13 say the files still need adding
  • docs/ROADMAP.md:71 (marked done)

Impact

Users enable the toggle and hear nothing. GAME_END is configured but never played.

Steps to reproduce

  1. Enable "Sound effects".
  2. Make a move. No audio; the network tab shows a failed request for assets/sounds/move.mp3.

Suggested fix

Either add six small, permissively licensed audio files, or synthesize short tones with the Web Audio API in playSound (no binary assets needed). Until then, hide the toggle and correct the README and ROADMAP lines. Play the game-end sound on checkmate and stalemate.

Acceptance criteria

  • Enabling the toggle produces sound for move, capture, check, castle, promotion and game end, or the toggle is hidden
  • README and ROADMAP match what ships

Getting started

  • Relevant files: js/config.js, js/utils.js, index.html, README.md
  • How to run tests: npm install, then npm test and npm run lint
  • Related docs: docs/ARCHITECTURE.md, .github/CONTRIBUTING.md

Filed by repo-audit/full-audit at 8a2c86c. Severity: low. Effort: S. audit-key: bug|js/config.js|ASSETS.SOUNDS

Lenguaje dominante
JavaScript
Estrellas
4
Forks
2
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/Static_Chess

Todos los issues de TMHSDigital/Static_Chess

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.