Sound effects toggle does nothing: no audio files are in the repository

Ouverte
  • Quelque chose ne va pas ?
#28 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
72/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript
Domaine
frontend

Piste de recherche

Start with js/config.js and js/utils.js to trace the configured sound paths and playSound, then inspect index.html and the game-end handling. Check the existing README and roadmap claims against the shipped behavior. Done means the sound toggle works for all listed events or is hidden, and the README and roadmap accurately describe the result.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug good first issue severity: low

Summary

The settings panel has a "Sound effects" toggle and the README lists sound as a feature, but assets/sounds/ does not exist. Turning the toggle on gives no sound and one failed request per move.

Where

  • js/config.js:38-45 (CONFIG.ASSETS.SOUNDS paths)
  • js/utils.js:184-193 (playSound, failure only logged)
  • index.html:50-56 (the toggle)
  • README.md:89, README.md:106, README.md:164 (feature claims); README.md:295 and CHANGELOG.md:13 say the files still need adding
  • docs/ROADMAP.md:71 (marked done)

Impact

Users enable the toggle and hear nothing. GAME_END is configured but never played.

Steps to reproduce

  1. Enable "Sound effects".
  2. Make a move. No audio; the network tab shows a failed request for assets/sounds/move.mp3.

Suggested fix

Either add six small, permissively licensed audio files, or synthesize short tones with the Web Audio API in playSound (no binary assets needed). Until then, hide the toggle and correct the README and ROADMAP lines. Play the game-end sound on checkmate and stalemate.

Acceptance criteria

  • Enabling the toggle produces sound for move, capture, check, castle, promotion and game end, or the toggle is hidden
  • README and ROADMAP match what ships

Getting started

  • Relevant files: js/config.js, js/utils.js, index.html, README.md
  • How to run tests: npm install, then npm test and npm run lint
  • Related docs: docs/ARCHITECTURE.md, .github/CONTRIBUTING.md

Filed by repo-audit/full-audit at 8a2c86c. Severity: low. Effort: S. audit-key: bug|js/config.js|ASSETS.SOUNDS

Langage dominant
JavaScript
Étoiles
4
Forks
2
Aucune PR mergée en 30 j

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/Static_Chess

Toutes les issues de TMHSDigital/Static_Chess

Issues similaires

Plus d'issues JavaScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.