Astro, Breakout, Pinball and Siege still keep their rules in the scene

Abierto
#86 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start with the reference pattern in games/pong/rules.ts and its tests, then open games/breakout/scenes/GameScene.ts, the suggested first candidate, and find pure functions for bounce angles, brick hits or level layout parsing. Move one game's functions into games/breakout/rules.ts with no Phaser import, add rules.test.ts, and have the scene call the module. Run npm test; done means the new tests pass and the scene behaves as before.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

severity: low tech-debt

Summary

Six games keep their rules in Phaser-free modules with unit tests (Stack, Snake, Maze, Runner, Hop and Pong). Astro Blaster, Neon Breakout, Neon Pinball and Star Siege still mix rules with input, audio and drawing in one scene class, so a rules regression in those four has no automated signal.

Where

  • games/astro/scenes/GameScene.ts (wave sizes, rock splitting, saucer timing and aim)
  • games/breakout/scenes/GameScene.ts (bounce angles, brick hits, power-up rolls, level layout parsing)
  • games/pinball/scenes/GameScene.ts (scoring and ball save, among others); the table data is already in games/pinball/table.ts
  • games/siege/scenes/GameScene.ts (formation movement, enemy fire selection, mothership scoring)
  • The pattern to follow: games/pong/rules.ts, games/hop/rules.ts, games/runner/rules.ts

Impact

Low. These games work today; the cost is that changes to them can only be checked by playing.

Suggested fix

One game per change, moving code rather than rewriting it, as was done for Pong:

  • Pick the functions that take plain numbers and return plain numbers (collision tests, scoring formulas, spawn rules).
  • Move them to games/<slug>/rules.ts with no Phaser import, passing a random function where the rule rolls dice.
  • Add rules.test.ts beside it and have the scene call the module.

Breakout is the best first candidate: its level layout parsing is also the first step of the level editor.

Acceptance criteria

  • Each of the four games has a Phaser-free rules module with unit tests
  • The scenes call the modules and behavior is unchanged

Getting started

  • Relevant files: the four scenes above and the three reference modules
  • How to run tests: npm test
  • Related docs: CONTRIBUTING.md ("Checks")

Related: #59, #40, #84


Filed by repo-audit/fix-issues at de2b25b. Severity: low. Effort: L. audit-key: tech-debt|games/astro/scenes/GameScene.ts|rules-extraction

Lenguaje dominante
TypeScript
Estrellas
3
Forks
3
Merge medio
10 h 22 min
PR fusionados (30 d)
6

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/GH-Arcade

Todos los issues de TMHSDigital/GH-Arcade

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.