Astro, Breakout, Pinball and Siege still keep their rules in the scene

Aberta
#86 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
62/100
Tipo de issue
Refatoração
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
game-dev, testing-qa

Direção de pesquisa

Start with the reference pattern in games/pong/rules.ts and its tests, then open games/breakout/scenes/GameScene.ts, the suggested first candidate, and find pure functions for bounce angles, brick hits or level layout parsing. Move one game's functions into games/breakout/rules.ts with no Phaser import, add rules.test.ts, and have the scene call the module. Run npm test; done means the new tests pass and the scene behaves as before.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

severity: low tech-debt

Summary

Six games keep their rules in Phaser-free modules with unit tests (Stack, Snake, Maze, Runner, Hop and Pong). Astro Blaster, Neon Breakout, Neon Pinball and Star Siege still mix rules with input, audio and drawing in one scene class, so a rules regression in those four has no automated signal.

Where

  • games/astro/scenes/GameScene.ts (wave sizes, rock splitting, saucer timing and aim)
  • games/breakout/scenes/GameScene.ts (bounce angles, brick hits, power-up rolls, level layout parsing)
  • games/pinball/scenes/GameScene.ts (scoring and ball save, among others); the table data is already in games/pinball/table.ts
  • games/siege/scenes/GameScene.ts (formation movement, enemy fire selection, mothership scoring)
  • The pattern to follow: games/pong/rules.ts, games/hop/rules.ts, games/runner/rules.ts

Impact

Low. These games work today; the cost is that changes to them can only be checked by playing.

Suggested fix

One game per change, moving code rather than rewriting it, as was done for Pong:

  • Pick the functions that take plain numbers and return plain numbers (collision tests, scoring formulas, spawn rules).
  • Move them to games/<slug>/rules.ts with no Phaser import, passing a random function where the rule rolls dice.
  • Add rules.test.ts beside it and have the scene call the module.

Breakout is the best first candidate: its level layout parsing is also the first step of the level editor.

Acceptance criteria

  • Each of the four games has a Phaser-free rules module with unit tests
  • The scenes call the modules and behavior is unchanged

Getting started

  • Relevant files: the four scenes above and the three reference modules
  • How to run tests: npm test
  • Related docs: CONTRIBUTING.md ("Checks")

Related: #59, #40, #84


Filed by repo-audit/fix-issues at de2b25b. Severity: low. Effort: L. audit-key: tech-debt|games/astro/scenes/GameScene.ts|rules-extraction

Linguagem predominante
TypeScript
Estrelas
3
Forks
3
Merge médio
10h 22min
PRs com merge (30d)
6

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/GH-Arcade

Todas as issues de TMHSDigital/GH-Arcade

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.