code-complexity: nested callbacks are counted into the enclosing function, and object-literal-returning functions are never measured

Abierto
#430 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
tooling

Línea de trabajo

Start with code-complexity-control.ts, especially lines 274–276, 336–365, and the file and function count checks at 130–174; read how the detector currently strips comments and finds function bodies. The issue suggests using TypeScript AST function-like nodes and ESLint’s complexity rule as a reference. Done means nested callbacks and literals no longer distort each function’s score, object-literal-returning functions are measured, and existing debt above 10 remains reported.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Found in the 8.0.0 self-audit triage: RoC 7.29.1 (npm, 5fc54afe) on a clean clone of develop at 2d2fa9a, with typescript resolvable (verdict compliance, 0 failed / 46 warnings). The bucket method and per-law tables are kept by QA; counts are from that run.

What happens

  • worstFunctionComplexity scores the brace body including inner functions (code-complexity-control.ts:336-365): 16 of 121 "function complexity" findings are an outer function charged with its callbacks (e.g. a score of 13 for a function whose own complexity is about 3).
  • Keywords, ?, || and braces inside strings/regex literals are counted and used for brace matching (only comments are stripped, :274-276): 23 more findings, e.g. a "function" scored 39 because brace matching ran on for 200 lines.
  • The other way round: a function whose return type is a multi-line object literal is never measured (admitted in the comment at :339-343); in already-flagged files this hides at least 12 functions over 10 (e.g. error-handling-completeness.ts:106, own complexity 22).
  • File length counts comment and blank lines (:130-139) and applies to data/constant tables; "too many functions" is a per-file ceiling independent of complexity (:148-174). These are threshold questions for the maintainers.

The detector reproduces exactly (121 of 121 worst-function numbers); 82 functions are genuinely over 10 and stay as debt.

Suggested direction

Standard per-function cyclomatic complexity of each function's own body (as ESLint's complexity rule), from the TypeScript AST; measure every function-like node.

Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
38 min
PR fusionados (30 d)
96

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Rule-Of-Code/RoC

Todos los issues de Rule-Of-Code/RoC

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.