code-complexity: nested callbacks are counted into the enclosing function, and object-literal-returning functions are never measured

Aperta
#430 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
tooling

Direzione di ricerca

Start with code-complexity-control.ts, especially lines 274–276, 336–365, and the file and function count checks at 130–174; read how the detector currently strips comments and finds function bodies. The issue suggests using TypeScript AST function-like nodes and ESLint’s complexity rule as a reference. Done means nested callbacks and literals no longer distort each function’s score, object-literal-returning functions are measured, and existing debt above 10 remains reported.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Found in the 8.0.0 self-audit triage: RoC 7.29.1 (npm, 5fc54afe) on a clean clone of develop at 2d2fa9a, with typescript resolvable (verdict compliance, 0 failed / 46 warnings). The bucket method and per-law tables are kept by QA; counts are from that run.

What happens

  • worstFunctionComplexity scores the brace body including inner functions (code-complexity-control.ts:336-365): 16 of 121 "function complexity" findings are an outer function charged with its callbacks (e.g. a score of 13 for a function whose own complexity is about 3).
  • Keywords, ?, || and braces inside strings/regex literals are counted and used for brace matching (only comments are stripped, :274-276): 23 more findings, e.g. a "function" scored 39 because brace matching ran on for 200 lines.
  • The other way round: a function whose return type is a multi-line object literal is never measured (admitted in the comment at :339-343); in already-flagged files this hides at least 12 functions over 10 (e.g. error-handling-completeness.ts:106, own complexity 22).
  • File length counts comment and blank lines (:130-139) and applies to data/constant tables; "too many functions" is a per-file ceiling independent of complexity (:148-174). These are threshold questions for the maintainers.

The detector reproduces exactly (121 of 121 worst-function numbers); 82 functions are genuinely over 10 and stay as debt.

Suggested direction

Standard per-function cyclomatic complexity of each function's own body (as ESLint's complexity rule), from the TypeScript AST; measure every function-like node.

Lingua principale
TypeScript
Stelle
0
Fork
0
Merge medio
38m
PR unite (30g)
96

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Rule-Of-Code/RoC

Tutte le issue di Rule-Of-Code/RoC

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.