pre-pr-quality-gates: GitHub branch protection is server-side but is required as a file; message prints "Missing " with an empty list

Abierto
#435 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
74/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github, typescript
Área
ci-cd, devtools

Línea de trabajo

Start in pre-pr-quality-gates.ts, especially the host check around lines 251–268 and message generation around lines 387–402; trace how the law handles remote hosts and collects violations. Check the existing tests for this law and add coverage for GitHub and GitLab remotes and for a branch-protection-only failure. Done means server-side protection is not reported as a missing local file, and the message names the actual violations.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Found in the 8.0.0 self-audit triage: RoC 7.29.1 (npm, 5fc54afe) on a clean clone of develop at 2d2fa9a, with typescript resolvable (verdict compliance, 0 failed / 46 warnings). The bucket method and per-law tables are kept by QA; counts are from that run.

What happens

The law reports "Missing branch protection configuration" for a GitHub repository whose develop and master are protected (GitHub API protected: true, two active rulesets). The detector only looks for .github/{branch_protection,branch-protection,settings}.yml (pre-pr-quality-gates.ts:196-247); isServerSideProtectionHost (:251-268) exempts Bitbucket and Azure but not GitHub or GitLab, although the code comment says protection is server-side. Also, generateMessage (:387-402) prints "Missing " with an empty list when only branch protection failed.

Suggested direction

Treat github.com and gitlab.com remotes as server-side protection hosts (or report not-judged instead of missing); build the message from the actual violations.

Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
38 min
PR fusionados (30 d)
96

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Rule-Of-Code/RoC

Todos los issues de Rule-Of-Code/RoC

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.