peer_reviewed_article: Saving without the author, title or image field passes null to the DOM (PHP 9.0)

Abierto
  • ¿Algo no está bien?
#600 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@guidol-ive ya está trabajando en esto.

Desde el 28/10/2026.

  • #602 de @guidol-ive — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
php
Área
backend

Línea de trabajo

Start in system/datatypes/peer_reviewed_article.php at editAction(), around lines 717–725, and compare the optional field handling in festival.php. Check how dataFor() behaves when author, title, or featured image is absent, then confirm saves with those fields omitted no longer pass null to DOM methods. Pull request #602 is already open for this issue.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Impact: Low Level: Easy Pagetype: Peer reviewed article Type: Bug Value: Coders

Problem. peer_reviewed_article::editAction() passes three form values straight to DOM methods:

  • system/datatypes/peer_reviewed_article.php:717-718: setAttribute(self::FIELD_NAME_AUTHOR, $form->dataFor(self::FIELD_NAME_AUTHOR))
  • :720: ->setText($form->dataFor(self::FIELD_NAME_TITLE))
  • :725: ->getOrCreate(self::FIELD_NAME_FEATURED_IMAGE)->setText($form->dataFor(self::FIELD_NAME_FEATURED_IMAGE))

dataFor() returns null for a field that is not in the post (for the featured image: when neither featured_image nor file_shadow_featured_image is posted). Passing null to a string parameter of an internal function is deprecated since PHP 8.1 and becomes a TypeError in PHP 9.0 (RFC: Deprecate passing null to non-nullable arguments of internal functions). On 9.0 such a save ends in a fatal error instead of storing empty values.

Messages on main (d97ab7b), PHP 8.2 and 8.5, for one post to <article>/edit with command save and only text, excerpt, method and sources:

Deprecated: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated in system/datatypes/peer_reviewed_article.php on line 718
Deprecated: DOMDocument::createTextNode(): Passing null to parameter #1 ($data) of type string is deprecated in system/core/database.php on line 488   (setText(), called from line 720 and 725)

The edit form in a browser always posts these fields (the shadow field of the image is added by HTMLForm::addFileShadowValueField()), so this hits a client that posts fewer fields, such as a script or an older form, not the normal editor. PHP 8.6.0RC4 runs the same code; its Apache image does not show the deprecation in the container log.

This is the same kind of fault as #408 (document.php:566), #588 (festival phone) and the festival website field in #559, in a place those do not cover.

Proposed fix (a suggestion and a starting point): give dataFor() the default '' for these three fields, as festival.php does for its optional fields. Works unchanged on PHP 8.2 up to 8.5.

🤖 Generated with Claude Code

Lenguaje dominante
JavaScript
Estrellas
5
Forks
9
Merge medio
18 h 49 min
PR fusionados (30 d)
13

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PlanBCode/hypha

Todos los issues de PlanBCode/hypha

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.