Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

peer_reviewed_article: Saving without the author, title or image field passes null to the DOM (PHP 9.0)

Aperta
  • Qualcosa non va?
#600 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@guidol-ive ci sta già lavorando.

Dal 28/10/2026.

  • #602 di @guidol-ive — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
php
Ambito
backend

Direzione di ricerca

Start in system/datatypes/peer_reviewed_article.php at editAction(), around lines 717–725, and compare the optional field handling in festival.php. Check how dataFor() behaves when author, title, or featured image is absent, then confirm saves with those fields omitted no longer pass null to DOM methods. Pull request #602 is already open for this issue.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Impact: Low Level: Easy Pagetype: Peer reviewed article Type: Bug Value: Coders

Problem. peer_reviewed_article::editAction() passes three form values straight to DOM methods:

  • system/datatypes/peer_reviewed_article.php:717-718: setAttribute(self::FIELD_NAME_AUTHOR, $form->dataFor(self::FIELD_NAME_AUTHOR))
  • :720: ->setText($form->dataFor(self::FIELD_NAME_TITLE))
  • :725: ->getOrCreate(self::FIELD_NAME_FEATURED_IMAGE)->setText($form->dataFor(self::FIELD_NAME_FEATURED_IMAGE))

dataFor() returns null for a field that is not in the post (for the featured image: when neither featured_image nor file_shadow_featured_image is posted). Passing null to a string parameter of an internal function is deprecated since PHP 8.1 and becomes a TypeError in PHP 9.0 (RFC: Deprecate passing null to non-nullable arguments of internal functions). On 9.0 such a save ends in a fatal error instead of storing empty values.

Messages on main (d97ab7b), PHP 8.2 and 8.5, for one post to <article>/edit with command save and only text, excerpt, method and sources:

Deprecated: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated in system/datatypes/peer_reviewed_article.php on line 718
Deprecated: DOMDocument::createTextNode(): Passing null to parameter #1 ($data) of type string is deprecated in system/core/database.php on line 488   (setText(), called from line 720 and 725)

The edit form in a browser always posts these fields (the shadow field of the image is added by HTMLForm::addFileShadowValueField()), so this hits a client that posts fewer fields, such as a script or an older form, not the normal editor. PHP 8.6.0RC4 runs the same code; its Apache image does not show the deprecation in the container log.

This is the same kind of fault as #408 (document.php:566), #588 (festival phone) and the festival website field in #559, in a place those do not cover.

Proposed fix (a suggestion and a starting point): give dataFor() the default '' for these three fields, as festival.php does for its optional fields. Works unchanged on PHP 8.2 up to 8.5.

🤖 Generated with Claude Code

Lingua principale
JavaScript
Stelle
5
Fork
9
Merge medio
19h 10m
PR unite (30g)
12

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PlanBCode/hypha

Tutte le issue di PlanBCode/hypha

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.