TBv3: results-table header, opened row and toolbar selection are near-identical lavenders

Abierto
  • ¿Algo no está bien?
#2,949 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript, react
Área
design

Línea de trabajo

Start with src/components/search/TableResults.jsx and src/components/search/SearchResults.jsx to compare the header, opened-row, and checked-row colors, then review the design-system tokens. The issue leaves the design choice open and allows closing as won't-do; discuss which direction to take before changing code. If a color change is chosen, record it on the design system's TableResults page (ocl-design-system#17) and include before/after screenshots showing all three states and hover.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

component/web decision/human-review signal/low-risk signal/needs-human signal/small-scope stage/triaged type/feature

Follow-up to ocl_issues#2948 (oclweb3#71), which gave results-table header rows a tinted background. Three nearby colours are now near-identical lavenders:

  • Header row: surface.s90 (#e3e0f9), in src/components/search/TableResults.jsx.
  • Opened row (the item shown in the side panel): primary.90 (#e2dfff), in the same file (ResultRow).
  • Results toolbar with rows checked: primary.main at the theme's activatedOpacity, in src/components/search/SearchResults.jsx.

When the first row is the opened one and some rows are checked, the toolbar, header and opened row read as one lavender block. oclweb3#71 added 1px surface.nv80 rules under the toolbar and header so the bands stay apart, but the colours themselves don't separate them. A before/after zoom is in oclweb3#71.

To consider: give the opened row (or the toolbar's selection state) a tone that's clearly different from the header, using design-system tokens, and record the choice in the design system's TableResults page (ocl-design-system#17). If we decide the rules are enough, close this as won't-do.

If we change it

  • The header, the opened row and the toolbar's selection state are each clearly distinguishable at a glance, light theme.
  • Hover and checked-row states stay distinct from all three.
  • The ocl-design-system TableResults page shows the new colours.
  • Before/after screenshots in the PR.
Lenguaje dominante
Sin datos de lenguaje
Estrellas
4
Forks
2
Merge medio
2 h 12 min
PR fusionados (30 d)
1

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenConceptLab/ocl_issues

Todos los issues de OpenConceptLab/ocl_issues

Issues similares

Más issues de Design

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.