TBv3: results-table header, opened row and toolbar selection are near-identical lavenders

未关闭
#2,949 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
javascript, react
领域
design

调研方向

Start with src/components/search/TableResults.jsx and src/components/search/SearchResults.jsx to compare the header, opened-row, and checked-row colors, then review the design-system tokens. The issue leaves the design choice open and allows closing as won't-do; discuss which direction to take before changing code. If a color change is chosen, record it on the design system's TableResults page (ocl-design-system#17) and include before/after screenshots showing all three states and hover.

由索引模型根据 Issue 内容生成。

描述

component/web decision/human-review signal/low-risk signal/needs-human signal/small-scope stage/triaged type/feature

Follow-up to ocl_issues#2948 (oclweb3#71), which gave results-table header rows a tinted background. Three nearby colours are now near-identical lavenders:

  • Header row: surface.s90 (#e3e0f9), in src/components/search/TableResults.jsx.
  • Opened row (the item shown in the side panel): primary.90 (#e2dfff), in the same file (ResultRow).
  • Results toolbar with rows checked: primary.main at the theme's activatedOpacity, in src/components/search/SearchResults.jsx.

When the first row is the opened one and some rows are checked, the toolbar, header and opened row read as one lavender block. oclweb3#71 added 1px surface.nv80 rules under the toolbar and header so the bands stay apart, but the colours themselves don't separate them. A before/after zoom is in oclweb3#71.

To consider: give the opened row (or the toolbar's selection state) a tone that's clearly different from the header, using design-system tokens, and record the choice in the design system's TableResults page (ocl-design-system#17). If we decide the rules are enough, close this as won't-do.

If we change it

  • The header, the opened row and the toolbar's selection state are each clearly distinguishable at a glance, light theme.
  • Hover and checked-row states stay distinct from all three.
  • The ocl-design-system TableResults page shows the new colours.
  • Before/after screenshots in the PR.
主要语言
没有语言数据
星标
4
派生
2
平均合并
2 小时 12 分钟
30 天内合并 PR
1

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenConceptLab/ocl_issues 的其他 Issue

查看 OpenConceptLab/ocl_issues 的全部 Issue

相似的 Issue

更多 Design Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。