Bug: `$clone` leaves `from_source_url` (and `to_source_url`) pointing at the original source on copied mappings

Abierto Apto para principiantes
  • ¿Algo no está bien?
#3,012 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Área
backend

Línea de trabajo

Empieza en core/sources/models.py, en clone_mappings(), y comprueba cómo Mapping.clone() copia las URL de origen. Compara los URI padre de los conceptos asignados con los valores copiados de from_source_url y to_source_url; actualiza la ruta de clonación para que esos campos coincidan con los conceptos asignados. Se considera terminado cuando los mappings copiados mediante $clone devuelvan las URL de origen de destino en la respuesta del detalle/API del mapping.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

component/api decision/human-review signal/needs-access signal/quick-win signal/small-scope signal/well-specified stage/triaged type/bug

Expected Behavior

When a concept is cloned into another source with $clone, each copied mapping belongs to the target source and starts from the new concept. So its from_source_url should be the target source, e.g. /orgs/PIH/sources/PIH/. More generally, from_source_url/to_source_url should match from_concept_url/to_concept_url and from_source_name/to_source_name.

Current Behavior

from_source_url keeps the value from the original mapping, i.e. the source the concept was cloned from, while from_concept_url and from_source_name are updated.

Example: PIH 21400 was cloned from CIEL 170656. CIEL mapping /orgs/CIEL/sources/CIEL/mappings/17052749/ is SAME-AS LOINC:53625-0. The copy, https://app.v3.openconceptlab.org/orgs/PIH/sources/PIH/mappings/44946/, has:

field value
from_concept_url /orgs/PIH/sources/PIH/concepts/21400/
from_source_name PIH
from_source_url /orgs/CIEL/sources/CIEL/
to_* LOINC 53625-0 (correct)

When the clone also retargets a mapping to a concept in the target source (see #3013), to_source_url isn't updated either. Example: https://app.v3.openconceptlab.org/orgs/PIH/sources/PIH/mappings/46475/ has to_concept_url=/orgs/PIH/sources/PIH/concepts/21768/ and to_source_name=PIH, but to_source_url=/orgs/CIEL/sources/CIEL/.

The concept view labels mappings by *_source_name, so the problem is only visible in the mapping detail/edit view or the API.

Possible Solution

In core/sources/models.py clone_mappings(), the code sets from_concept_id, from_concept_code, from_source_id (and the to_* equivalents) from the assigned concepts, but not from_source_url/to_source_url. Mapping.clone() copies those URLs from the original. Setting them from the assigned concepts' parent (concept.parent.uri) would fix it.

Steps to Reproduce

  1. Pick a CIEL concept with mappings to other sources, e.g. CIEL 170656.
  2. Clone it into a source you can edit, using TermBrowser "Clone to source" (v2 or v3) or POST <target source>/concepts/$clone/ with equivalencyMapType=SAME-AS.
  3. GET the new concept with ?includeMappings=true, then GET one of its copied mappings with ?verbose=true.
  4. from_source_url is the CIEL source, not the target source.

Context (Environment)

Production (api.openconceptlab.org), PIH organization source /orgs/PIH/sources/PIH/. In release 1.8.46 about 3,850 copied mappings have this, going back to March 2024. The OpenMRS OCL module doesn't use from_source_url, so imports aren't affected, but the data is inconsistent and confusing for anyone reading or editing the mappings.

Detailed Description

Found while investigating a related, more serious clone problem: mappings to external code systems being retargeted to concepts in the target source (#3013). That issue also leaves to_source_url stale.

Lenguaje dominante
Sin datos de lenguaje
Estrellas
4
Forks
2
Merge medio
2 h 12 min
PR fusionados (30 d)
1

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenConceptLab/ocl_issues

Todos los issues de OpenConceptLab/ocl_issues

Issues similares

Más issues de Backend & API Design

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.