Show Charging page faults from the fault feed

Abierto
  • ¿Algo no está bien?
#959 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@SimeonChenchev1 ya está trabajando en esto.

Desde el 6/11/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

by: ai-assisted dev work frontend
What

The Charging page's fault display watches a hard-coded list of BMS and charger fault topics and works out when each fault is raised. That list goes stale whenever the car's fault definitions change, which is what #902 had to fix. Make it show BMS and charger faults from the same fault feed the Faults page uses, so it picks up whatever faults scylla-server reports for those CAN nodes.

Diagram
flowchart LR
  subgraph Before
    S1[Siren] --> SC1[scylla-server] -->|"data, per topic"| FD1["Charging fault display<br/>(hard-coded topic list)"]
  end
  subgraph After
    S2[Siren] --> SC2[scylla-server] -->|"faults event"| FS[FaultService]
    FS --> FP[Faults page]
    FS -->|"Bms and Charger nodes"| FD2[Charging fault display]
  end
Requirements
  • The Charging page fault display gets its faults from the same fault feed as the Faults page, not from its own topic list
  • It shows the same BMS and charger faults it shows today
  • A new BMS or charger fault that scylla-server reports appears without any change to the client
  • The fault display's hard-coded topic list and the topic helpers only it uses are removed
  • Desktop and mobile Charging page layouts both show the faults
Notes
  • The Faults page lives in pages/fault-page; FaultService is in services/fault.service.ts. The fault feed is filled from the socket's "faults" event in socket.service.ts.
  • scylla-server decides what counts as a fault in socket_handler.rs. BMS faults are any topic under BMS/Faults/, charger faults any topic under Charger/Box/F_, so both already reach the feed. A fault is marked expired after 8 seconds without being seen again.
  • The feed sends the whole list of recent faults every second, not just new ones. Each item has its node, name, first-seen time, last-seen time and an expired flag.
  • Open question: should expired faults still be listed, maybe greyed out, or hidden? And should the display's reset button still clear the list?
  • Follows the review on PR #954.
Lenguaje dominante
TypeScript
Estrellas
5
Forks
1
Merge medio
1 d 8 h
PR fusionados (30 d)
35

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Northeastern-Electric-Racing/Argos

Todos los issues de Northeastern-Electric-Racing/Argos

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.