Show Charging page faults from the fault feed

Aperta
  • Qualcosa non va?
#959 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@SimeonChenchev1 ci sta già lavorando.

Dal 6/11/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

by: ai-assisted dev work frontend
What

The Charging page's fault display watches a hard-coded list of BMS and charger fault topics and works out when each fault is raised. That list goes stale whenever the car's fault definitions change, which is what #902 had to fix. Make it show BMS and charger faults from the same fault feed the Faults page uses, so it picks up whatever faults scylla-server reports for those CAN nodes.

Diagram
flowchart LR
  subgraph Before
    S1[Siren] --> SC1[scylla-server] -->|"data, per topic"| FD1["Charging fault display<br/>(hard-coded topic list)"]
  end
  subgraph After
    S2[Siren] --> SC2[scylla-server] -->|"faults event"| FS[FaultService]
    FS --> FP[Faults page]
    FS -->|"Bms and Charger nodes"| FD2[Charging fault display]
  end
Requirements
  • The Charging page fault display gets its faults from the same fault feed as the Faults page, not from its own topic list
  • It shows the same BMS and charger faults it shows today
  • A new BMS or charger fault that scylla-server reports appears without any change to the client
  • The fault display's hard-coded topic list and the topic helpers only it uses are removed
  • Desktop and mobile Charging page layouts both show the faults
Notes
  • The Faults page lives in pages/fault-page; FaultService is in services/fault.service.ts. The fault feed is filled from the socket's "faults" event in socket.service.ts.
  • scylla-server decides what counts as a fault in socket_handler.rs. BMS faults are any topic under BMS/Faults/, charger faults any topic under Charger/Box/F_, so both already reach the feed. A fault is marked expired after 8 seconds without being seen again.
  • The feed sends the whole list of recent faults every second, not just new ones. Each item has its node, name, first-seen time, last-seen time and an expired flag.
  • Open question: should expired faults still be listed, maybe greyed out, or hidden? And should the display's reset button still clear the list?
  • Follows the review on PR #954.
Lingua principale
TypeScript
Stelle
5
Fork
1
Merge medio
1g 20h
PR unite (30g)
38

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Northeastern-Electric-Racing/Argos

Tutte le issue di Northeastern-Electric-Racing/Argos

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.