WeatherFileDays and WeatherFileConditionType are never translated and have no API

Abierto
  • ¿Algo no está bien?
#5,674 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 10 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp
Área
api, backend

Línea de trabajo

Start by tracing the WeatherFileDays and WeatherFileConditionType model classes, the ForwardTranslator’s sizing period handling, and the matching ReverseTranslator paths; inspect how SimulationControl counts sizing periods. Compare both model objects with their EnergyPlus fields, including the two missing fields and version translation. Done means both types round-trip through IDF translation with their fields represented and sizing controls behave correctly.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

General Summary

OS:SizingPeriod:WeatherFileDays and OS:SizingPeriod:WeatherFileConditionType exist in the model, but the classes WeatherFileDays and WeatherFileConditionType have no getters or setters, and the ForwardTranslator drops both with "is not currently translated" (since 772e66de65, 2015). DesignDay is the only sizing period that reaches EnergyPlus.

Detailed Description

EnergyPlus can size on periods of the weather file (SizingPeriod:WeatherFileDays, SizingPeriod:WeatherFileConditionType) instead of synthetic design days. In OpenStudio today:

  1. A WeatherFileDays added to a model disappears from the IDF, with only a Warn log line.
  2. SimulationControl counts it as a SizingPeriod: doZoneSizingCalculation and doSystemSizingCalculation default to on when any SizingPeriod exists. A model whose only sizing periods are WeatherFileDays therefore translates to an IDF that requests zone and system sizing without any sizing period.
  3. OS:SizingPeriod:WeatherFileDays lacks the last two EnergyPlus fields, Use Weather File Daylight Saving Period and Use Weather File Rain and Snow Indicators (OS:SizingPeriod:WeatherFileConditionType has them).

Today these sizing periods can only be added with an EnergyPlusMeasure after translation.

Possible Implementation
  • Getters and setters for all fields of both classes.
  • Add Use Weather File Daylight Saving Period and Use Weather File Rain and Snow Indicators to OS:SizingPeriod:WeatherFileDays, with version translation.
  • translateWeatherFileDays / translateWeatherFileConditionType in the ForwardTranslator (1:1), plus ReverseTranslator. A warning when the model has no WeatherFile would help, since EnergyPlus needs one for these periods.
Lenguaje dominante
C++
Estrellas
657
Forks
238
Merge medio
11 d 12 h
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NatLabRockies/OpenStudio

Todos los issues de NatLabRockies/OpenStudio

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.