WeatherFileDays and WeatherFileConditionType are never translated and have no API

Aperta
  • Qualcosa non va?
#5,674 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 10 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
api, backend

Direzione di ricerca

Start by tracing the WeatherFileDays and WeatherFileConditionType model classes, the ForwardTranslator’s sizing period handling, and the matching ReverseTranslator paths; inspect how SimulationControl counts sizing periods. Compare both model objects with their EnergyPlus fields, including the two missing fields and version translation. Done means both types round-trip through IDF translation with their fields represented and sizing controls behave correctly.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

General Summary

OS:SizingPeriod:WeatherFileDays and OS:SizingPeriod:WeatherFileConditionType exist in the model, but the classes WeatherFileDays and WeatherFileConditionType have no getters or setters, and the ForwardTranslator drops both with "is not currently translated" (since 772e66de65, 2015). DesignDay is the only sizing period that reaches EnergyPlus.

Detailed Description

EnergyPlus can size on periods of the weather file (SizingPeriod:WeatherFileDays, SizingPeriod:WeatherFileConditionType) instead of synthetic design days. In OpenStudio today:

  1. A WeatherFileDays added to a model disappears from the IDF, with only a Warn log line.
  2. SimulationControl counts it as a SizingPeriod: doZoneSizingCalculation and doSystemSizingCalculation default to on when any SizingPeriod exists. A model whose only sizing periods are WeatherFileDays therefore translates to an IDF that requests zone and system sizing without any sizing period.
  3. OS:SizingPeriod:WeatherFileDays lacks the last two EnergyPlus fields, Use Weather File Daylight Saving Period and Use Weather File Rain and Snow Indicators (OS:SizingPeriod:WeatherFileConditionType has them).

Today these sizing periods can only be added with an EnergyPlusMeasure after translation.

Possible Implementation
  • Getters and setters for all fields of both classes.
  • Add Use Weather File Daylight Saving Period and Use Weather File Rain and Snow Indicators to OS:SizingPeriod:WeatherFileDays, with version translation.
  • translateWeatherFileDays / translateWeatherFileConditionType in the ForwardTranslator (1:1), plus ReverseTranslator. A warning when the model has no WeatherFile would help, since EnergyPlus needs one for these periods.
Lingua principale
C++
Stelle
657
Fork
238
Merge medio
4g 15h
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NatLabRockies/OpenStudio

Tutte le issue di NatLabRockies/OpenStudio

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.