fix(core): the game loop stops silently when a library hook throws

Abierto
  • ¿Algo no está bien?
#478 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
game-dev

Línea de trabajo

Start with packages/core/src/application/nanoforge-application.ts lines 95–121, where the async loop runs library hooks and schedules the next tick; inspect the existing stop and teardown paths there. Add coverage under packages/core/test for a throwing hook and for a throwing __clear; done means the loop reports the error, stops cleanly, continues teardown across failing clears, and notifies stop observers.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug packages:core
Which package is this bug report for?

core

Issue description

loop is an async function scheduled with setTimeout. When a __events / __run hook rejects (for example a system throws inside ecs.runSystems), this.schedule(loop, …) is never reached and the rejection is unhandled. The game freezes with no error, no __clear, no viewport dispose and no onStop for observers such as the editor; on Bun the server process exits. The teardown branch also stops at the first __clear that throws.

Where:

Evidence:

for (const library of orderedForRun) await runHook(library, "__events");
...
for (const library of orderedForRun) await runHook(library, "__run");
...
this.schedule(loop, tickLengthMs + tickStart - Date.now());

Suggested fix: Wrap the tick body in try/catch: log the error, requestStop(), then run the normal teardown, isolating each __clear. Add a test with a throwing hook (packages/core/test has none).

Found during a code audit of main at be72076.

Code sample

No response

Versions
  • Engine main at be72076
  • pnpm 12.0.0, Node.js 26, Bun 1.3.14
Issue priority

High (immediate attention needed)

I have tested this issue on a development release

be72076

Lenguaje dominante
TypeScript
Estrellas
7
Forks
2
Merge medio
1 d 17 h
PR fusionados (30 d)
17

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NanoForge-dev/Engine

Todos los issues de NanoForge-dev/Engine

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.