Align Unified Search visibility with participant access rules

Abierto
#9,066 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
18/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php

Línea de trabajo

Start by reading how lib/Search/FileSearchProvider.php filters results and how lib/Service/FileAccessService.php decides document access, then compare the participant lookups in lib/Db/SignRequestMapper.php and the identification types in lib/Db/IdentifyMethod.php. The issue asks for a written role/identity/state matrix before any code change, so the first deliverable is that contract, checked against tests/php/Unit/Service/FileAccessServiceTest.php. Done means the matrix is agreed and the positive and negative cases pass, and any separately exploitable finding goes through SECURITY.md, not a public pull request.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

backend enhancement php

Goal

Ensure LibreSign Unified Search uses consistent participant identity and document-access rules for owners, signers and observers.

Starting points

  • lib/Search/FileSearchProvider.php
  • lib/Db/SignRequestMapper.php
  • lib/Service/FileAccessService.php
  • lib/Db/IdentifyMethod.php
  • lib/Db/SignRequest.php
  • tests/php/Unit/Service/FileAccessServiceTest.php
  • Existing observer integration scenarios

Requirements

Define and implement a consistent, testable contract for search discovery.

Account UID associations should be handled explicitly. Email and other identification channels require a verified rule for associating the contact with the authenticated account; merely comparing arbitrary contact strings must not expand access.

Cover current signing-request states, observers, envelopes, draft requests, deleted accounts and legacy records.

Search discovery must not confer signing, validation or document-management permissions.

Keep discovery decisions consistent with document-access checks without introducing per-result authorization queries that undermine performance.

Acceptance criteria

  • A concise role/identity/state matrix documents expected visibility.
  • Owners, account signers and account observers receive the correct results.
  • Ambiguous or untrusted identifiers do not grant unintended discovery.
  • Unrelated accounts receive no document identifiers or metadata.
  • Multiple identification methods do not create duplicate results.
  • Revoked, stale and deleted-account scenarios have defined outcomes.
  • Search-related authorization checks are read-only.
  • Unit and database integration tests cover positive and negative cases.
  • Existing legitimate signing and validation flows remain compatible.

Implementation guidance

Use the existing services as the starting point. Establish the authorization contract first, then implement the smallest change that satisfies it.

Avoid an independent new permission framework or a repository-wide refactor.

If investigation suggests a separately exploitable security issue, follow SECURITY.md instead of describing exploitation details in a public pull request.

Lenguaje dominante
PHP
Estrellas
844
Forks
176
Merge medio
14 h 3 min
PR fusionados (30 d)
344

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de LibreSign/libresign

Todos los issues de LibreSign/libresign

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.