Audit the remaining deferred ESLint rules and document justified exceptions

Abierto
#9,503 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
8/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
eslint, javascript

Línea de trabajo

Start with the effective rule configuration in eslint.config.mjs and the .editorconfig tab convention, then check the cited files src/components/PdfEditor/Signature.vue and src/views/Settings/ConfigureCheck.vue, where v-html renders row.message. Done means one decision record per rule (enable, defer with a dependency, or intentionally disable with a justification) backed by a fresh lint inventory on the base SHA, plus a review of #9498-#9502 and PR #9497 on main. This needs maintainer policy decisions, so it is not a first-timer task.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

frontend javascript technical debt

Goal

Make an evidence-based, maintainable decision about the 16 remaining deferred ESLint rules not covered by #9498-#9502. This is a technical classification and final handoff, not a mass-refactor task.

Rules in scope

  • Translations: @nextcloud/l10n-enforce-ellipsis, @nextcloud/l10n-non-breaking-space.
  • Vue/API contracts: vue/attribute-hyphenation, vue/custom-event-name-casing, vue/slot-name-casing, vue/v-on-event-hyphenation, vue/no-v-html, vue/multi-word-component-names, camelcase.
  • Indentation: @stylistic/indent, @stylistic/no-tabs.
  • Documentation: jsdoc/require-jsdoc, jsdoc/require-param, jsdoc/require-param-description.
  • Other: antfu/top-level-function, vue/no-unused-properties.

Evidence to collect

  1. Capture base SHA and a fresh current lint inventory for every rule; include effective preset options and affected files. Existing eslint.config.mjs hit counts are historical.
  2. Classify each rule as enable now, defer with a stated dependency, or intentionally disabled with a technical justification. Record evidence, tradeoffs, affected contracts, test strategy and accountable maintainer decision.
  3. Verify examples before deciding: .editorconfig requires tabs, so @stylistic/no-tabs conflicts with the current project convention; src/components/PdfEditor/Signature.vue emits onUpdate/onDelete; src/views/Settings/ConfigureCheck.vue uses v-html on row.message; the policy catalog uses HTML highlighting with explicit escaping. Do not assume these all have the same risk or that changing names is harmless.
  4. Avoid dummy JSDoc comments and cosmetic renames of Vue events, slots or backend/API field names. Treat translation strings and generated artifacts as protected boundaries.
  5. Review the final implementation results of #9498-#9502 and PR #9497 against the actual integrated main, including lint/type/build/test checks; do not infer success from closed issue counts.
  6. If the audit finds further independent implementation deliverables, propose them for separate approval rather than quietly expanding the task or closing the epic prematurely. Report security-sensitive HTML findings through the appropriate private disclosure process when needed.

Deliverable / acceptance criteria

  • One per-rule decision record for all 16 rules, with current measured evidence and relevant contracts.
  • Decisions are explicitly reviewed for Vue/API/translation/security impacts; unresolved decisions are not labeled complete.
  • Justified intentional disables have concise, non-stale explanations near the effective configuration.
  • Integrated checks on main have been verified or report the exact blocker.
  • The epic's final acceptance criteria can be judged without relying solely on a 100% sub-issue counter.

Out of scope and contributor suitability

Do not mass-change runtime code, Vue event names, API fields, translations or indentation while producing this audit. The work requires policy and architecture decisions; keep it available for maintainers/experienced contributors, not good first issue.

Additional context

Development workflow: https://docs.libresign.coop/developer_manual/development-workflow.html
Questions: https://t.me/LibreSign

Lenguaje dominante
PHP
Estrellas
844
Forks
176
Merge medio
14 h 3 min
PR fusionados (30 d)
344

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de LibreSign/libresign

Todos los issues de LibreSign/libresign

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.