Align Unified Search visibility with participant access rules

未关闭
#9,066 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
18/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
php

调研方向

Start by reading how lib/Search/FileSearchProvider.php filters results and how lib/Service/FileAccessService.php decides document access, then compare the participant lookups in lib/Db/SignRequestMapper.php and the identification types in lib/Db/IdentifyMethod.php. The issue asks for a written role/identity/state matrix before any code change, so the first deliverable is that contract, checked against tests/php/Unit/Service/FileAccessServiceTest.php. Done means the matrix is agreed and the positive and negative cases pass, and any separately exploitable finding goes through SECURITY.md, not a public pull request.

由索引模型根据 Issue 内容生成。

描述

backend enhancement php

Goal

Ensure LibreSign Unified Search uses consistent participant identity and document-access rules for owners, signers and observers.

Starting points

  • lib/Search/FileSearchProvider.php
  • lib/Db/SignRequestMapper.php
  • lib/Service/FileAccessService.php
  • lib/Db/IdentifyMethod.php
  • lib/Db/SignRequest.php
  • tests/php/Unit/Service/FileAccessServiceTest.php
  • Existing observer integration scenarios

Requirements

Define and implement a consistent, testable contract for search discovery.

Account UID associations should be handled explicitly. Email and other identification channels require a verified rule for associating the contact with the authenticated account; merely comparing arbitrary contact strings must not expand access.

Cover current signing-request states, observers, envelopes, draft requests, deleted accounts and legacy records.

Search discovery must not confer signing, validation or document-management permissions.

Keep discovery decisions consistent with document-access checks without introducing per-result authorization queries that undermine performance.

Acceptance criteria

  • A concise role/identity/state matrix documents expected visibility.
  • Owners, account signers and account observers receive the correct results.
  • Ambiguous or untrusted identifiers do not grant unintended discovery.
  • Unrelated accounts receive no document identifiers or metadata.
  • Multiple identification methods do not create duplicate results.
  • Revoked, stale and deleted-account scenarios have defined outcomes.
  • Search-related authorization checks are read-only.
  • Unit and database integration tests cover positive and negative cases.
  • Existing legitimate signing and validation flows remain compatible.

Implementation guidance

Use the existing services as the starting point. Establish the authorization contract first, then implement the smallest change that satisfies it.

Avoid an independent new permission framework or a repository-wide refactor.

If investigation suggests a separately exploitable security issue, follow SECURITY.md instead of describing exploitation details in a public pull request.

主要语言
PHP
星标
844
派生
176
平均合并
14 小时 3 分钟
30 天内合并 PR
344

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

LibreSign/libresign 的其他 Issue

查看 LibreSign/libresign 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。