Align Unified Search visibility with participant access rules
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 18/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- php
- 领域
- authorization, search
调研方向
Start by reading how lib/Search/FileSearchProvider.php filters results and how lib/Service/FileAccessService.php decides document access, then compare the participant lookups in lib/Db/SignRequestMapper.php and the identification types in lib/Db/IdentifyMethod.php. The issue asks for a written role/identity/state matrix before any code change, so the first deliverable is that contract, checked against tests/php/Unit/Service/FileAccessServiceTest.php. Done means the matrix is agreed and the positive and negative cases pass, and any separately exploitable finding goes through SECURITY.md, not a public pull request.
由索引模型根据 Issue 内容生成。
描述
Goal
Ensure LibreSign Unified Search uses consistent participant identity and document-access rules for owners, signers and observers.
Starting points
lib/Search/FileSearchProvider.phplib/Db/SignRequestMapper.phplib/Service/FileAccessService.phplib/Db/IdentifyMethod.phplib/Db/SignRequest.phptests/php/Unit/Service/FileAccessServiceTest.php- Existing observer integration scenarios
Requirements
Define and implement a consistent, testable contract for search discovery.
Account UID associations should be handled explicitly. Email and other identification channels require a verified rule for associating the contact with the authenticated account; merely comparing arbitrary contact strings must not expand access.
Cover current signing-request states, observers, envelopes, draft requests, deleted accounts and legacy records.
Search discovery must not confer signing, validation or document-management permissions.
Keep discovery decisions consistent with document-access checks without introducing per-result authorization queries that undermine performance.
Acceptance criteria
- A concise role/identity/state matrix documents expected visibility.
- Owners, account signers and account observers receive the correct results.
- Ambiguous or untrusted identifiers do not grant unintended discovery.
- Unrelated accounts receive no document identifiers or metadata.
- Multiple identification methods do not create duplicate results.
- Revoked, stale and deleted-account scenarios have defined outcomes.
- Search-related authorization checks are read-only.
- Unit and database integration tests cover positive and negative cases.
- Existing legitimate signing and validation flows remain compatible.
Implementation guidance
Use the existing services as the starting point. Establish the authorization contract first, then implement the smallest change that satisfies it.
Avoid an independent new permission framework or a repository-wide refactor.
If investigation suggests a separately exploitable security issue, follow SECURITY.md instead of describing exploitation details in a public pull request.
- 主要语言
- PHP
- 星标
- 844
- 派生
- 176
- 平均合并
- 14 小时 3 分钟
- 30 天内合并 PR
- 344
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
LibreSign/libresign 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
OpenSSL engine: leaf certificates get O=Internet Widgits Pty Ltd, ST=Some-State from system openssl.cnf可能已有人在做 @vitormattos 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
LibreSign/libresign#9366 · 已指派 1 人 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 83/100
LibreSign/libresign#9007 · 2 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 1-3 小时 新手友好度 78/100
LibreSign/libresign#8284 · 5 条评论 ·
维护者通常 1 天内回复
-
frontend javascript technical debt
难度 5/5 一周以上 新手友好度 8/100
维护者通常 1 天内回复
查看 LibreSign/libresign 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 79/100
Automattic/blocks-engine#6318 ·
维护者通常 1 天内回复
-
kind/enhancement
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletons未关闭
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 1/5 1 小时以内 新手友好度 88/100
-
难度 1/5 1 小时以内 新手友好度 82/100