React 19 foundation: run tests against 19, then drop React 16/17
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 55/100
- Tipo de issue
- Refactorización
- Claridad
- Bien especificado
- Estado de actividad
- Tranquilo
- Stack tecnológico
- github-actions, react, typescript
Línea de trabajo
Comienza con la matriz de trabajos de prueba, package.json y el archivo de bloqueo para rastrear las combinaciones actuales de React y Node. Incorpora primero la cobertura del trabajo de prueba de React 19 y, después, verifica que la dependencia peer indicada, la eliminación del shim, la matriz de CI y la suite de React 19 en verde cumplan los criterios de aceptación.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Tracking issue for the v5 React 19 foundation. Two PRs, in this order.
Why this is first
Every other v5 cluster sits on top of it, and one half of it is a gap rather than a migration: CI type-checks React 19 but has never executed a test against it. The type-check job carries matrix.react: ["18","19"]; the test job's matrix is Node versions only, and the lockfile resolves React 18.2.0. So executed coverage on 19 is zero today.
PR 1: React 19 as an executed test job (CI only)
Adds a react dimension to the test job so the suite actually runs on 19.
This lands first and alone, before any src/ change. The use-sync-external-store shim delegates to React.useSyncExternalStore when it exists, so the suite runs on React 19 with the shim still in place. That gives a measured baseline to compare against once the shim is deleted, instead of changing the runtime and the dependency in one step.
⚠️ Not a one-line matrix addition. The test job currently matrixes node: [22, 24] only. Adding a react dimension doubles the emulator jobs from two to four, each with its own Java setup and emulator cache.
⚠️ That interacts with #776. The firestore flake sits at 7.5% per full-suite run, so doubling the emulator jobs roughly doubles per-PR exposure to a red job. Deliberately not putting a number on it: contention is the suspected mechanism, so the jobs are correlated rather than independent, and multiplying the rate would overstate the precision. This argues for #787's timing data landing before the matrix widens.
Reviewable by anyone; no src/ change, no API surface.
PR 2: drop React 16/17
One PR, one review:
peerDependencies.react:>=16 || experimentalbecomes^18 || ^19- delete the
use-sync-external-storeshim and its dependency - drop the 16/17 entries from the CI matrix
Splitting these buys a second review round trip on what is a single decision.
Acceptance
peerDependencies.reactreads^18 || ^19use-sync-external-storeis absent frompackage.json- the test job runs on React 19 and is green, with the shim gone
Notes
- The
use()suspend-gate swap is out of scope. Spiked: it is a behavioural no-op on React 19.2.8 and React 19 emits no warning for the current throw form, so there is no deprecation pressure and no reason to bundle it here. - Related to #788. "CI type-checks React 19 but never runs a test against it" is a live instance of the pattern that issue collects: a check that passes while measuring nothing. #788 currently has no example attached to it.
- The React floor is
^18 || ^19, not 19-only. Dropping 18 is not part of this.
- Lenguaje dominante
- TypeScript
- Estrellas
- 3.6k
- Forks
- 403
- Merge medio
- 5 d 1 h
- PR fusionados (30 d)
- 10
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de FirebaseExtended/reactfire
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 38/100
FirebaseExtended/reactfire#801 ·
-
v5
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
FirebaseExtended/reactfire#793 ·
-
v5
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
FirebaseExtended/reactfire#790 · 2 comentarios ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
FirebaseExtended/reactfire#788 ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
FirebaseExtended/reactfire#784 ·
Todos los issues de FirebaseExtended/reactfire
Issues similares
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Crush Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
ElementsProject/cln-application#167 · 1 comentario · 1 reacción ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Quantco/pnpm-licenses#17 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100