Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

React 19 foundation: run tests against 19, then drop React 16/17

Offen
#789 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
55/100
Issue-Typ
Refactoring
Klarheit
Klar beschrieben
Aktivitätsstatus
Ruhig
Tech-Stack
github-actions, react, typescript
Bereich
ci-cd, testing

Rechercherichtung

Beginne mit der Testjob-Matrix, package.json und der Lockdatei, um die aktuellen React- und Node-Kombinationen nachzuverfolgen. Führe zuerst die Abdeckung des React-19-Testjobs ein und überprüfe anschließend, dass die angegebene Peer-Abhängigkeit, die Entfernung des Shims, die CI-Matrix und die erfolgreiche React-19-Suite die Akzeptanzkriterien erfüllen.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

v5

Tracking issue for the v5 React 19 foundation. Two PRs, in this order.

Why this is first

Every other v5 cluster sits on top of it, and one half of it is a gap rather than a migration: CI type-checks React 19 but has never executed a test against it. The type-check job carries matrix.react: ["18","19"]; the test job's matrix is Node versions only, and the lockfile resolves React 18.2.0. So executed coverage on 19 is zero today.

PR 1: React 19 as an executed test job (CI only)

Adds a react dimension to the test job so the suite actually runs on 19.

This lands first and alone, before any src/ change. The use-sync-external-store shim delegates to React.useSyncExternalStore when it exists, so the suite runs on React 19 with the shim still in place. That gives a measured baseline to compare against once the shim is deleted, instead of changing the runtime and the dependency in one step.

⚠️ Not a one-line matrix addition. The test job currently matrixes node: [22, 24] only. Adding a react dimension doubles the emulator jobs from two to four, each with its own Java setup and emulator cache.

⚠️ That interacts with #776. The firestore flake sits at 7.5% per full-suite run, so doubling the emulator jobs roughly doubles per-PR exposure to a red job. Deliberately not putting a number on it: contention is the suspected mechanism, so the jobs are correlated rather than independent, and multiplying the rate would overstate the precision. This argues for #787's timing data landing before the matrix widens.

Reviewable by anyone; no src/ change, no API surface.

PR 2: drop React 16/17

One PR, one review:

  • peerDependencies.react: >=16 || experimental becomes ^18 || ^19
  • delete the use-sync-external-store shim and its dependency
  • drop the 16/17 entries from the CI matrix

Splitting these buys a second review round trip on what is a single decision.

Acceptance

  • peerDependencies.react reads ^18 || ^19
  • use-sync-external-store is absent from package.json
  • the test job runs on React 19 and is green, with the shim gone

Notes

  • The use() suspend-gate swap is out of scope. Spiked: it is a behavioural no-op on React 19.2.8 and React 19 emits no warning for the current throw form, so there is no deprecation pressure and no reason to bundle it here.
  • Related to #788. "CI type-checks React 19 but never runs a test against it" is a live instance of the pattern that issue collects: a check that passes while measuring nothing. #788 currently has no example attached to it.
  • The React floor is ^18 || ^19, not 19-only. Dropping 18 is not part of this.
Vorherrschende Sprache
TypeScript
Sterne
3.6k
Forks
403
Ø Merge
5 T. 1 Std.
Gemergte PRs (30 T.)
10

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus FirebaseExtended/reactfire

Alle Issues in FirebaseExtended/reactfire

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.