Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

The observable cache leaks subscriptions and is shared across SSR requests

Abierto
#790 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
backend, testing

Línea de trabajo

Comienza con SuspenseSubject.ts, especialmente con el constructor, _subscribe, _reset y hasValue; después, sigue la vinculación de la caché a nivel de módulo en useObservable.ts y las tres exportaciones de preload. Revisa el comportamiento de SSR con renderToPipeableStream. Se considera terminado cuando las solicitudes concurrentes no comparten entradas, el renderizado en el servidor no deja suscripciones abiertas y las entradas de la caché se desalojan.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

v5

Tracking issue for cluster 0b. #748 covers only the getServerSnapshot half of this (fixed by #779); the cache lifecycle itself has never had an issue.

Everything below was verified against upstream/v5 on 2026-08-11 unless labelled otherwise.

Two defects, one lifecycle

1. Nothing is ever evicted, and the reset timer is cancelled permanently by the first subscriber.

_timeoutHandler is assigned only in the SuspenseSubject constructor (SuspenseSubject.ts:61,63) and cleared only in _subscribe (:124). Nothing re-arms it. So the first subscriber cancels the reset for the life of the object, and _reset() can only ever fire on an entry that nothing subscribed to within the timeout window.

⚠️ The comment at SuspenseSubject.ts:58 says the timer reschedules "on unsubscribe". That code was never written.

Separately, nothing removes entries from the cache Map at all: a sweep for preloadedObservables.delete / .clear across src/ on v5 returns zero hits, and the same sweep for .set / .has / .get returns three, so the search can come back non-empty.

Consequence: any cache entry that is ever used leaks its warmup subscription for the life of the process. Not SSR-only, the browser leaks too, bounded only by session length, which is likely why it has never been reported. A server has no such bound, and keys are per-user (firestore:doc:app:users/<uid>).

2. The cache is a module-level global, so concurrent SSR requests share entries.

useObservable.ts:11 binds the Map at import time off globalThis. ⚠️ Swapping globalThis._reactFirePreloadedObservables does not redirect it: the module keeps writing to the original object, silently. Any test that isolates that way is testing nothing.

Why this is a prerequisite, not cleanup

Measured under renderToPipeableStream (what the App Router runs, and it surfaces what renderToString hides):

  • In suspense mode reactfire suspends, waits for the emission, then renders the placeholder anyway, so the caller pays full latency for a loading state.
  • A cold cache in suspense mode hangs the stream rather than erroring, because firstEmission only resolves on a first emission.

So until the cache is request-scoped there is no way to server-render real data at all. Anything that seeds per-request data on a server depends on this landing first.

Plan: one decision, then three PRs

Decision first: suspense-mode eviction semantics. Error state persists indefinitely in suspense mode via a noop timeout, and resets after the window in non-suspense mode. Eviction has to pick a rule. Not a PR, and it overlaps #742, which asks for a retry path out of the same error state.

PR A. Browser lifecycle: refcount, re-arm, evict. Independent of SSR and a live bug today, so it is the half worth shipping even if the rest slips. Behavior change, no new API.

PR B. Per-request scoping via an explicit cache handle: createObservableCache(), a cache prop, an optional trailing argument on the three preload exports. Prototyped: scoping falls out, the preload API survives, no Node-only APIs, browser behaviour unchanged when omitted. New API surface.

PR C. Server disposal, riding on that handle. ⚠️ Scoping must never ship without it: alone, scoping converts one shared leak into one leak per request.

#779 lands ahead of all of it, since it is the getServerSnapshot half.

Acceptance

  • a test proving two concurrent SSR requests do not share cache entries
  • ⚠️ a test proving a server render leaves no open subscription and that entries are evicted

The second signal exists because the first one alone passes with every subscription still open and nothing evicted. That was caught on the prototype.

Notes

  • Estimated 5-6 days. An estimate, not a measurement.
  • ⚠️ hasValue (SuspenseSubject.ts:67-71) returning this._hasValue || !!this._error is load-bearing: it is what stops suspense re-throwing after the promise resolves. A naive redefinition produces an infinite suspend loop. It reads like a wart and a rewrite deletes it by accident.
  • Ruled out: React 19 cache() (RSC-only), AsyncLocalStorage (unnecessary once a handle threads through, kept in reserve), not caching on the server (does not survive the leak finding).
  • Zero confirmed users of the v4 preload API, though a code search cannot see private code, so "zero confirmed" rather than "zero".
Lenguaje dominante
TypeScript
Estrellas
3.6k
Forks
403
Merge medio
5 d 1 h
PR fusionados (30 d)
10

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de FirebaseExtended/reactfire

Todos los issues de FirebaseExtended/reactfire

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.