Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Nothing handles SIGTERM, so every deploy interrupts in-flight work

Abierto
  • ¿Algo no está bien?
#330 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@michljoe ya está trabajando en esto.

Desde el 16/10/2026.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
40/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
nodejs, postgresql, redis, typescript
Área
backend

Línea de trabajo

Start in src/index.ts, where the ingester loops and the HTTP listener are started, and check how Prisma and Redis are opened. Look at src/api/websocket.ts to see how clients are connected. Use src/alerts/delivery.ts as the pattern for the grace-period timeout. The test goes in src/tests/ and runs with vitest. Done means the acceptance criteria pass: both signals trigger one ordered drain, the grace period is configurable and logged when exceeded, and a second signal does not start another drain.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:reliability difficulty:intermediate help wanted points:150 Stellar Wave
Background

There is no signal handler anywhere in src/. The only process.on match in
the tree is inside a comment in src/api/websocket.ts. So on every deploy the
platform sends SIGTERM, Node's default handler exits immediately, and whatever
was in flight stops where it stood: a half-written batch of price points, an
open Prisma transaction, a Redis job claimed but not acknowledged, and every
websocket client dropped without a close frame.

Lens runs ingesters as infinite background loops started from src/index.ts,
which makes this worse than it would be for a plain request/response service —
there is always something in flight.

What to build
  • A shutdown handler for SIGTERM and SIGINT that stops accepting new work,
    lets in-flight work finish within a bounded grace period, then exits.
  • Order matters: stop the ingester loops and the HTTP listener first, drain, then
    close Prisma and Redis.
  • A hard deadline so a stuck drain cannot hang the deploy forever. Log loudly if
    the deadline is hit rather than exiting silently.
  • Make it idempotent — a second SIGTERM during shutdown must not start a second drain.
Acceptance criteria
  • SIGTERM and SIGINT both trigger a graceful shutdown
  • The HTTP server stops accepting connections before dependencies close
  • Prisma and Redis are closed explicitly
  • A bounded grace period exists and is configurable; exceeding it is logged
  • A test proves a second signal during shutdown does not re-enter the drain

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lenguaje dominante
TypeScript
Estrellas
4
Forks
71
Merge medio
1 d 15 h
PR fusionados (30 d)
28

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Divinity-Labs/Lens

Todos los issues de Divinity-Labs/Lens

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.