Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Webhook retries have no jitter, so failures synchronise

Abierto Apto para principiantes
  • ¿Algo no está bien?
#341 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
80/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
nodejs, typescript
Área
backend

Línea de trabajo

Empieza en src/alerts/delivery.ts, donde retryDelayMs calcula el backoff determinista de 1 s/2 s/4 s y el bucle de reintentos lo invoca. Añade jitter completo detrás de una fuente de aleatoriedad inyectable, manteniendo el límite de intentos existente y la regla de que las respuestas 4xx no se reintentan. Ejecuta un único archivo de vitest con npx vitest run src/tests/<file>.test.ts, usando la fuente de aleatoriedad fija para demostrar que dos fallos simultáneos se reintentan en momentos distintos. Está terminado cuando los retrasos tienen jitter, el test pasa de forma determinista y el comportamiento de 4xx y del límite de intentos no cambia.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:reliability difficulty:easy help wanted points:100 Stellar Wave
Background

src/alerts/delivery.ts backs off deterministically:

function retryDelayMs(attempt: number): number {
  return Math.pow(2, attempt - 1) * 1000
}

Every delivery that fails at the same moment retries at exactly the same moment
— 1s, then 2s, then 4s. A price movement is precisely the event that triggers
many alerts at once, so when a subscriber's endpoint has a wobble, Lens responds
by hitting it with a synchronised burst, three times, which is a good way to
turn a wobble into an outage.

What to build
  • Add jitter. Full jitter — a random value between zero and the computed delay —
    is the standard choice and is one line.
  • Keep the existing retry count and the existing rule that 4xx is not retried,
    which is correct.
  • Make the test deterministic by injecting the randomness rather than asserting
    on a range.
Acceptance criteria
  • Retry delays are jittered
  • Two deliveries failing simultaneously retry at different times, asserted by a test
  • 4xx responses are still not retried
  • The attempt cap is unchanged
  • The randomness source is injectable so the test is not flaky

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lenguaje dominante
TypeScript
Estrellas
4
Forks
71
Merge medio
1 d 15 h
PR fusionados (30 d)
28

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Divinity-Labs/Lens

Todos los issues de Divinity-Labs/Lens

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.