Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Nothing handles SIGTERM, so every deploy interrupts in-flight work

オープン
  • 何か問題がありますか？
#330 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@michljoe がすでに取り組んでいます。

2026年10月16日 から。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
40/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
nodejs, postgresql, redis, typescript
領域
backend

調査の方向性

Start in src/index.ts, where the ingester loops and the HTTP listener are started, and check how Prisma and Redis are opened. Look at src/api/websocket.ts to see how clients are connected. Use src/alerts/delivery.ts as the pattern for the grace-period timeout. The test goes in src/tests/ and runs with vitest. Done means the acceptance criteria pass: both signals trigger one ordered drain, the grace period is configurable and logged when exceeded, and a second signal does not start another drain.

索引モデルが issue の本文から書いたものです。

説明

area:reliability difficulty:intermediate help wanted points:150 Stellar Wave
Background

There is no signal handler anywhere in src/. The only process.on match in
the tree is inside a comment in src/api/websocket.ts. So on every deploy the
platform sends SIGTERM, Node's default handler exits immediately, and whatever
was in flight stops where it stood: a half-written batch of price points, an
open Prisma transaction, a Redis job claimed but not acknowledged, and every
websocket client dropped without a close frame.

Lens runs ingesters as infinite background loops started from src/index.ts,
which makes this worse than it would be for a plain request/response service —
there is always something in flight.

What to build
  • A shutdown handler for SIGTERM and SIGINT that stops accepting new work,
    lets in-flight work finish within a bounded grace period, then exits.
  • Order matters: stop the ingester loops and the HTTP listener first, drain, then
    close Prisma and Redis.
  • A hard deadline so a stuck drain cannot hang the deploy forever. Log loudly if
    the deadline is hit rather than exiting silently.
  • Make it idempotent — a second SIGTERM during shutdown must not start a second drain.
Acceptance criteria
  • SIGTERM and SIGINT both trigger a graceful shutdown
  • The HTTP server stops accepting connections before dependencies close
  • Prisma and Redis are closed explicitly
  • A bounded grace period exists and is configurable; exceeding it is logged
  • A test proves a second signal during shutdown does not re-enter the drain

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
1日 15時間
マージ済み PR（30日）
28

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。