Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Five of six outbound fetches cannot time out

Cerrado
  • ¿Algo no está bien?
#328 2 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 2 días

@decrypted-dev ya está trabajando en esto.

Desde el 16/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

area:reliability difficulty:intermediate help wanted points:150 Stellar Wave
Background

src/alerts/delivery.ts gets this right:

res = await fetch(url, {
  method: 'POST',
  headers: { 'Content-Type': 'application/json', 'X-Lens-Signature': signature },
  body: payload,
  signal: AbortSignal.timeout(10_000),
})

Every other outbound call in the service omits the signal entirely:

src/ingest/venues/aquarius.ts:54   await fetch(`${apiUrl}?${params.toString()}`)
src/ingesters/amm.ts:36            await fetch(`${horizon}/liquidity_pools?…`)
src/ingesters/amm.ts:133           await fetch(…)
src/ingesters/soroswap.ts:75       await fetch(tokenListUrl)
src/mcp/server.ts:83               await fetch(endpoint)

fetch has no default timeout in Node. A TCP connection that is accepted and
then never answered — which is exactly what a hung upstream or a dropped NAT
mapping looks like — leaves that await pending forever. The ingester holding
it does not crash, so restartIngester never fires: the venue simply stops
producing prices, silently, until someone redeploys.

What to build
  • A single helper that wraps fetch with a deadline, used by all five sites.
    Keep the existing AbortSignal.timeout approach — the point is one
    convention, not a new one.
  • A timeout must be distinguishable from an empty response at the call site, so
    that L163's work can report it. Throw rather than returning a falsy value.
  • The deadline should be configurable per call, because an MCP tool call and a
    Horizon page fetch do not deserve the same budget. Give it a sensible default.
Acceptance criteria
  • No fetch( call in src/ is without a timeout
  • One helper is used by every call site; delivery.ts keeps working
  • A test proves a hung server causes a rejected promise within the deadline, not a pending one
  • The timeout value is configurable and documented in .env.example if it becomes an env var

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lenguaje dominante
TypeScript
Estrellas
4
Forks
71
Merge medio
2 d 20 h
PR fusionados (30 d)
127

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Divinity-Labs/Lens

Todos los issues de Divinity-Labs/Lens

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.