Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Five of six outbound fetches cannot time out

オープン
  • 何か問題がありますか？
#328 コメント 2 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@decrypted-dev がすでに取り組んでいます。

2026年10月16日 から。

評価

この issue はまだ評価されていません。

説明

area:reliability difficulty:intermediate help wanted points:150 Stellar Wave
Background

src/alerts/delivery.ts gets this right:

res = await fetch(url, {
  method: 'POST',
  headers: { 'Content-Type': 'application/json', 'X-Lens-Signature': signature },
  body: payload,
  signal: AbortSignal.timeout(10_000),
})

Every other outbound call in the service omits the signal entirely:

src/ingest/venues/aquarius.ts:54   await fetch(`${apiUrl}?${params.toString()}`)
src/ingesters/amm.ts:36            await fetch(`${horizon}/liquidity_pools?…`)
src/ingesters/amm.ts:133           await fetch(…)
src/ingesters/soroswap.ts:75       await fetch(tokenListUrl)
src/mcp/server.ts:83               await fetch(endpoint)

fetch has no default timeout in Node. A TCP connection that is accepted and
then never answered — which is exactly what a hung upstream or a dropped NAT
mapping looks like — leaves that await pending forever. The ingester holding
it does not crash, so restartIngester never fires: the venue simply stops
producing prices, silently, until someone redeploys.

What to build
  • A single helper that wraps fetch with a deadline, used by all five sites.
    Keep the existing AbortSignal.timeout approach — the point is one
    convention, not a new one.
  • A timeout must be distinguishable from an empty response at the call site, so
    that L163's work can report it. Throw rather than returning a falsy value.
  • The deadline should be configurable per call, because an MCP tool call and a
    Horizon page fetch do not deserve the same budget. Give it a sensible default.
Acceptance criteria
  • No fetch( call in src/ is without a timeout
  • One helper is used by every call site; delivery.ts keeps working
  • A test proves a hung server causes a rejected promise within the deadline, not a pending one
  • The timeout value is configurable and documented in .env.example if it becomes an env var

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

主要言語
TypeScript
スター
4
フォーク
71
平均マージ
1日 15時間
マージ済み PR（30日）
28

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Divinity-Labs/Lens のほかの issue

Divinity-Labs/Lens の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。