Add option to preserve pre-existing HTML sizes attributes on images
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 52/100
Línea de trabajo
Empieza por localizar el flujo de opciones de Optimole y el analizador de etiquetas HTML responsable de reemplazar los atributos sizes. Determina cómo deberían representarse la configuración o el atributo de datos compatible y, después, añade cobertura de pruebas unitarias para conservar los atributos sizes preexistentes. Se considera terminado cuando una configuración activa deja esos atributos intactos.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Impact: 75 · Confidence: 95 · Complexity: 35
Description
Problem
When Optimole processes frontend images, its Page Profiler replaces existing HTML sizes attributes with automatically measured slot dimensions. Site developers who have crafted accurate sizes attributes (e.g. for hero images or complex responsive layouts) find their attributes overwritten. Currently, the only way to prevent Optimole from replacing a sizes attribute is using CSS function workarounds like calc(100vw).
Desired Behavior
Provide an official plugin configuration setting or supported attribute (e.g. data-optml-keep-sizes or a global setting 'Preserve existing sizes attributes') so site administrators can prevent Optimole from overwriting manually defined HTML sizes attributes.
Acceptance Criteria
- Add a setting in Optimole options or support a specific HTML data attribute to skip sizes attribute replacement.
- When active/present, Optimole's HTML tag parser leaves existing sizes attributes untouched.
- Include unit test coverage verifying pre-existing sizes attributes are preserved when the setting or attribute is present.
Customer Context
The customer has hand-crafted sizes attributes on photography listings and hero images. Optimole overwrites these with inaccurate profiler-generated slot measurements. The customer asks for an official setting or supported attribute to preserve existing sizes attributes without relying on calc() workarounds.
Root Cause Analysis
The customer manages an image-centric photography site and encountered multiple issues stemming from Optimole's automated HTML replacement and page profiler logic: 1) Optimole automatically overwrites HTML sizes attributes with measured slot widths unless explicit CSS functions like calc() are detected, leaving site authors who create custom responsive sizes attributes without a supported setting to preserve their HTML markup. 2) Profiled srcset candidate generation applies DPR transformations in a way that causes candidate descriptors to mismatch delivered image intrinsic widths when Retina Quality is active. 3) Page Profiler slot extrapolation calculates incorrect viewport slot widths on mobile layouts. 4) Duplicate max-width conditions are generated in sizes strings. 5) Database queries executed during the output buffer shutdown callback trigger MySQL 'Commands out of sync' errors. While issues #1111-#1114 address the specific bug regressions, an official setting/option to preserve existing sizes attributes fulfills an unaddressed gap in product configuration.
Reasoning
The customer conversation contains 5 distinct filable requests/reports: 1) Request for an official configuration option or mechanism to preserve pre-existing HTML sizes attributes on images rather than having Optimole overwrite them (new_feature_request). 2) Bug report that profiled srcset width descriptors mismatch delivered intrinsic image widths when Retina Quality is enabled, already tracked in GitHub issue #1111 (already_exists_github). 3) Bug report regarding inaccurate responsive slot widths extrapolated by Page Profiler, already tracked in issue #1112 (already_exists_github). 4) Bug report regarding duplicate max-width conditions in generated sizes attributes, already tracked in issue #1113 (already_exists_github). 5) Bug report regarding MySQL 'Commands out of sync' errors caused by PageProfiler transient reads during shutdown, already tracked in issue #1114 (already_exists_github). The top-level decision reflects the new, actionable feature request.
Source: HelpScout #3424946418
Generated by feature-request-triage workflow (ID: feature-request-triage_6a8821dfeacaf1.56068976)
- Lenguaje dominante
- PHP
- Estrellas
- 73
- Forks
- 14
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 16
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Codeinwp/optimole-wp
-
bug-report bug-report-triage crash-report
Dificultad 4/5 3-5 días Aptitud para principiantes 65/100
Codeinwp/optimole-wp#1162 ·
Los mantenedores suelen responder en 1 día
-
customer report feature-request-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 65/100
Codeinwp/optimole-wp#1161 ·
Los mantenedores suelen responder en 1 día
-
bug-report bug-report-triage customer report regression
Dificultad 4/5 3-5 días Aptitud para principiantes 56/100
Codeinwp/optimole-wp#1159 ·
Los mantenedores suelen responder en 1 día
-
customer report feature-request-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
Codeinwp/optimole-wp#1151 ·
Los mantenedores suelen responder en 1 día
-
bug-report bug-report-triage crash-report
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
Codeinwp/optimole-wp#1139 ·
Los mantenedores suelen responder en 1 día
Todos los issues de Codeinwp/optimole-wp
Issues similares
-
sync-en
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 2 días
-
P2 testing
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
Los mantenedores suelen responder en 1 día
-
1.severity: security
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Automattic/static-site-importer#1879 ·
Los mantenedores suelen responder en 1 día
-
bug Installation / Upgrade
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día