Add option to preserve pre-existing HTML sizes attributes on images
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
首先定位 Optimole 选项流程，以及负责替换 sizes 属性的 HTML 标签解析器。确定应如何表示该设置或受支持的数据属性，然后添加用于保留现有 sizes 属性的单元测试覆盖。完成标准是：启用的配置不会更改这些属性。
由索引模型根据 Issue 内容生成。
描述
Impact: 75 · Confidence: 95 · Complexity: 35
Description
Problem
When Optimole processes frontend images, its Page Profiler replaces existing HTML sizes attributes with automatically measured slot dimensions. Site developers who have crafted accurate sizes attributes (e.g. for hero images or complex responsive layouts) find their attributes overwritten. Currently, the only way to prevent Optimole from replacing a sizes attribute is using CSS function workarounds like calc(100vw).
Desired Behavior
Provide an official plugin configuration setting or supported attribute (e.g. data-optml-keep-sizes or a global setting 'Preserve existing sizes attributes') so site administrators can prevent Optimole from overwriting manually defined HTML sizes attributes.
Acceptance Criteria
- Add a setting in Optimole options or support a specific HTML data attribute to skip sizes attribute replacement.
- When active/present, Optimole's HTML tag parser leaves existing sizes attributes untouched.
- Include unit test coverage verifying pre-existing sizes attributes are preserved when the setting or attribute is present.
Customer Context
The customer has hand-crafted sizes attributes on photography listings and hero images. Optimole overwrites these with inaccurate profiler-generated slot measurements. The customer asks for an official setting or supported attribute to preserve existing sizes attributes without relying on calc() workarounds.
Root Cause Analysis
The customer manages an image-centric photography site and encountered multiple issues stemming from Optimole's automated HTML replacement and page profiler logic: 1) Optimole automatically overwrites HTML sizes attributes with measured slot widths unless explicit CSS functions like calc() are detected, leaving site authors who create custom responsive sizes attributes without a supported setting to preserve their HTML markup. 2) Profiled srcset candidate generation applies DPR transformations in a way that causes candidate descriptors to mismatch delivered image intrinsic widths when Retina Quality is active. 3) Page Profiler slot extrapolation calculates incorrect viewport slot widths on mobile layouts. 4) Duplicate max-width conditions are generated in sizes strings. 5) Database queries executed during the output buffer shutdown callback trigger MySQL 'Commands out of sync' errors. While issues #1111-#1114 address the specific bug regressions, an official setting/option to preserve existing sizes attributes fulfills an unaddressed gap in product configuration.
Reasoning
The customer conversation contains 5 distinct filable requests/reports: 1) Request for an official configuration option or mechanism to preserve pre-existing HTML sizes attributes on images rather than having Optimole overwrite them (new_feature_request). 2) Bug report that profiled srcset width descriptors mismatch delivered intrinsic image widths when Retina Quality is enabled, already tracked in GitHub issue #1111 (already_exists_github). 3) Bug report regarding inaccurate responsive slot widths extrapolated by Page Profiler, already tracked in issue #1112 (already_exists_github). 4) Bug report regarding duplicate max-width conditions in generated sizes attributes, already tracked in issue #1113 (already_exists_github). 5) Bug report regarding MySQL 'Commands out of sync' errors caused by PageProfiler transient reads during shutdown, already tracked in issue #1114 (already_exists_github). The top-level decision reflects the new, actionable feature request.
Source: HelpScout #3424946418
Generated by feature-request-triage workflow (ID: feature-request-triage_6a8821dfeacaf1.56068976)
- 主要语言
- PHP
- 星标
- 73
- 派生
- 14
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 18
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
Codeinwp/optimole-wp 的其他 Issue
-
bug-report bug-report-triage crash-report regression
难度 4/5 3-5 天 新手友好度 45/100
Codeinwp/optimole-wp#1163 ·
维护者通常 1 天内回复
-
bug-report bug-report-triage crash-report
难度 4/5 3-5 天 新手友好度 65/100
Codeinwp/optimole-wp#1162 ·
维护者通常 1 天内回复
-
customer report feature-request-triage
难度 3/5 1-2 天 新手友好度 65/100
Codeinwp/optimole-wp#1161 ·
维护者通常 1 天内回复
-
bug-report bug-report-triage customer report regression
难度 4/5 3-5 天 新手友好度 56/100
Codeinwp/optimole-wp#1159 ·
维护者通常 1 天内回复
-
customer report feature-request-triage
难度 3/5 1-2 天 新手友好度 55/100
Codeinwp/optimole-wp#1151 ·
维护者通常 1 天内回复
查看 Codeinwp/optimole-wp 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 3 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
维护者通常 1 天内回复
-
sync-en
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
sync-en
难度 2/5 1-2 天 新手友好度 84/100
维护者通常 2 天内回复
-
feature-request needs-triage
难度 2/5 1-3 小时 新手友好度 72/100
aws/aws-sdk-php#3365 ·
维护者通常 1 天内回复