Allow WP-CLI `wp optimole media rollback_images` command to execute when `offload_media` is set to rollback state
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 65/100
Línea de trabajo
Look at the WP-CLI command handler for wp optimole media rollback_images, likely in a class like Optml_Media_Offload. The validation check for the offload_media option needs to be adjusted to also allow execution when the storage mode is 'rollback'. Examine how the plugin state is stored and identify the condition that signifies an active rollback. Test the command after changes to ensure it works both when offload is enabled and during a rollback.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Impact: 75 · Confidence: 95 · Complexity: 30
Description
- Problem: When a site administrator initiates an image transfer/rollback from the plugin dashboard ('Transfer back from Optimole'), Optimole sets the plugin storage mode to rollback, which stores the
offload_mediasetting option as disabled. If the administrator or host then attempts to run the command-line rollback tool (wp optimole media rollback_images), the WP-CLI command throws an error:Error: You need to have the offload_media option enabled in order to use this commandand aborts. - Desired behavior: WP-CLI's
wp optimole media rollback_imagescommand should check whether a rollback is currently active or in progress (or allow execution ifoffload_mediais disabled due to an ongoing rollback state), rather than strictly requiringoffload_mediato be enabled. - Acceptance Criteria:
- Running
wp optimole media rollback_imagessucceeds when an image rollback operation has been initiated from the dashboard (whereoffload_mediais disabled or set to rollback mode). - The CLI command only rejects execution if no offloaded images exist or if offload media was never configured/active.
Customer Context
The customer needed to roll back 11,000+ offloaded images. The background WP-Cron process stalled due to server cron restrictions. When support instructed the customer and host to run wp optimole media rollback_images via SSH/terminal, the WP-CLI command failed because selecting 'Transfer back from Optimole' in the plugin dashboard had set offload_media to disabled.
Root Cause Analysis
The customer needed to restore offloaded media back to the local WordPress Media Library. The plugin's UI dashboard action 'Transfer back from Optimole' sets the plugin's offload storage mode to rollback, which sets the offload_media option value to disabled. When background WP-Cron stalled and support instructed the host to run wp optimole media rollback_images via WP-CLI, the CLI command failed because it enforces a strict check requiring offload_media to be enabled before initiating or resuming a rollback. The root cause is a workflow/validation contradiction in the plugin code: initiating a rollback in UI turns off offload_media, but the CLI command requires offload_media to be enabled.
Alternative Suggestions
Relax or adjust the option check in Optml_Media_Offload / WP-CLI rollback command handler so that wp optimole media rollback_images checks whether offloaded images exist or whether storage mode is in rollback state, rather than strictly asserting offload_media == enabled.
Reasoning
The customer experienced a failure running the CLI rollback command wp optimole media rollback_images because selecting 'Transfer back from Optimole' in the WordPress admin dashboard saved the storage mode as rollback, which updated offload_media option to disabled. Consequently, when attempting to run wp optimole media rollback_images via CLI as recommended for reliable or large background operations, WP-CLI halts with Error: You need to have the offload_media option enabled in order to use this command. The CLI rollback command should automatically permit execution when offload_media is in a rollback state or automatically bypass this option check during a rollback operation.
Source: HelpScout #3456031569
Generated by feature-request-triage workflow (ID: feature-request-triage_6ab502db326f90.60727165)
- Lenguaje dominante
- PHP
- Estrellas
- 73
- Forks
- 14
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 16
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Codeinwp/optimole-wp
-
bug-report bug-report-triage crash-report
Dificultad 4/5 3-5 días Aptitud para principiantes 65/100
Codeinwp/optimole-wp#1162 ·
Los mantenedores suelen responder en 1 día
-
bug-report bug-report-triage customer report regression
Dificultad 4/5 3-5 días Aptitud para principiantes 56/100
Codeinwp/optimole-wp#1159 ·
Los mantenedores suelen responder en 1 día
-
customer report feature-request-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
Codeinwp/optimole-wp#1151 ·
Los mantenedores suelen responder en 1 día
-
bug-report bug-report-triage crash-report
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
Codeinwp/optimole-wp#1139 ·
Los mantenedores suelen responder en 1 día
-
bug-report bug-report-triage customer report
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Codeinwp/optimole-wp#1136 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de Codeinwp/optimole-wp
Issues similares
-
sync-en
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
az-digital/az_quickstart#6077 ·
Los mantenedores suelen responder en 1 día
-
Toolkit
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
[Bug] v-quick-install-app install crashes with ValueError if no supported PHP version is installedAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
Add `kjkpc.net`Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
FGRibreau/mailchecker#625 ·