Color palette as CSS variables logs wp.components.Theme warnings in the Site Editor
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 62/100
Línea de trabajo
Start by reading the settings.color.palette entries in theme.json and note which ones are var(--nv-…, #hex) values (ti-bg, ti-fg, and the rest). Then find where Assets_Manager prints the inherited inline CSS so the --wp--preset--color--ti-* overrides can move there. Done looks like literal hex values in the palette, Neve-migrated sites still showing Neve's colours, and no wp.components.Theme warnings in the Site Editor console with SCRIPT_DEBUG on.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
The theme's colour palette is defined as CSS variables, which the Site Editor's own colour handling can't read. Every time the Site Editor opens, the browser console shows three warnings:
wp.components.Theme: "var(--nv-text-color, #202020)" is not a valid color value for the 'accent' prop.
wp.components.Theme: "var(--nv-site-bg, #FFFFFF)" is not a valid color value for the 'background' prop.
wp.components.Theme: The background color ("var(--nv-site-bg, #FFFFFF)") does not have sufficient contrast against the accent color ("var(--nv-text-color, #202020)").
Every entry of theme.json settings.color.palette is a var(--nv-…, #hex) value, so that a site coming from Neve inherits Neve's colours (ti-bg is var(--nv-site-bg, #FFFFFF), ti-fg is var(--nv-text-color, #202020), and so on). The Site Editor passes the palette's background and foreground to wp.components.Theme, which expects literal colours. So it can't compute the canvas UI's colours or the contrast check from them.
Step-by-step reproduction instructions
- With Eduacademy 1.0.1 active and
SCRIPT_DEBUGon, go to Appearance → Editor. - Open the browser console.
Expected: no warnings from the theme's palette.
Actual: the three wp.components.Theme warnings above, on every Site Editor load, and on every template or part opened in it.
Screenshots, screen recording, code snippet or Help Scout ticket
Possible fix: keep literal hex values in theme.json's palette, and apply the Neve overrides through the inherited inline CSS that Assets_Manager already prints (overriding the --wp--preset--color--ti-* variables there). The palette entries would then be real colours, while a site coming from Neve still gets Neve's colours.
Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). Seen on WordPress 7.0.9, 7.1-RC1 and 7.1.5 alike.
Environment info
Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, SCRIPT_DEBUG on, Chromium.
Is the issue you are reporting a regression
No
- Lenguaje dominante
- PHP
- Estrellas
- 0
- Forks
- 0
- Merge medio
- 22 h 12 min
- PR fusionados (30 d)
- 6
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Codeinwp/eduacademy
-
bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 84/100
Codeinwp/eduacademy#30 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Codeinwp/eduacademy#31 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Codeinwp/eduacademy#29 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Codeinwp/eduacademy#28 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
Codeinwp/eduacademy#6 ·
Todos los issues de Codeinwp/eduacademy
Issues similares
-
Change: check an identifier filter the same way in every tool - the order of somcp_search_ordersAbiertoconsistency enhancement Orders
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
novalo-dev/Prestashop-MCP-Server#343 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
claude
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
sprain/sprainocchio#45 ·
Los mantenedores suelen responder en 1 día
-
sync-en
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
sync-en
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día