Patterns content-1 and features-2 request missing media 108–110 (404s in the editor)

Abierto Apto para principiantes
#30 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
84/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
php, wordpress
Área
frontend

Línea de trabajo

Abre inc/patterns/layout/content-1.php (bloques Cover en las líneas 62, 74, 120) y inc/patterns/layout/features-2.php (bloques Image en las líneas 56, 70), y elimina los atributos "id" sobrantes, además de cualquier clase wp-image-<id> en los bloques Image, manteniendo las URL de Assets_Manager::get_image_url(). Lee primero #3 para ver por qué se recablearon las URL. Hecho significa que la Front Page del Site Editor y las vistas previas del inserter cargan sin solicitudes a /wp-json/wp/v2/media/108–110 en la pestaña Network.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Description

Two of the theme's patterns point at images by attachment ID from the site they were made on. On any other site those attachments don't exist, so whenever the editor shows these patterns it asks for them and gets 404 (Not Found) in the browser console. That happens in the Site Editor (the Front Page template uses content-1), in the block inserter's previews, and in the editor.

  • inc/patterns/layout/content-1.php: three Cover blocks with "id":108 (line 62), "id":109 (line 74) and "id":110 (line 120). Their url already comes from Assets_Manager::get_image_url(); only the IDs are left over.
  • inc/patterns/layout/features-2.php: two Image blocks with "id":108 (line 56) and "id":109 (line 70).

The images themselves display, because the URLs point at the theme's own assets/img/ files. But the IDs trigger the failed requests on every site, and on a site that does have attachments 108–110 they would point the blocks at unrelated media from that site's library.

Related: #3, where content-1's images were being wired to Assets_Manager::get_image_url.

Step-by-step reproduction instructions
  1. On any site with Eduacademy 1.0.1 active, open the browser's developer tools (Console and Network tabs).
  2. Go to Appearance → Editor → Templates → Front Page.
  3. Watch the Network tab.

Expected: no failed requests.
Actual: GET /wp-json/wp/v2/media/108, /109 and /110 answer 404, and the console shows three "Failed to load resource" errors. The same happens when inserting the patterns from Patterns → Eduacademy Patterns.

Screenshots, screen recording, code snippet or Help Scout ticket

Fix suggestion: drop the "id" attribute (and the matching wp-image-<id> class on Image blocks, if present) from these five blocks, so they keep only the theme-asset URL.

Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). The same happens on every WordPress version tried (7.0.9, 7.1-RC1, 7.1.5).

Environment info

Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, Chromium.

Is the issue you are reporting a regression

No

Lenguaje dominante
PHP
Estrellas
0
Forks
0
Merge medio
22 h 12 min
PR fusionados (30 d)
6

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Codeinwp/eduacademy

Todos los issues de Codeinwp/eduacademy

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.