Color palette as CSS variables logs wp.components.Theme warnings in the Site Editor

Aperta
#32 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php, wordpress
Ambito
design, frontend

Direzione di ricerca

Start by reading the settings.color.palette entries in theme.json and note which ones are var(--nv-…, #hex) values (ti-bg, ti-fg, and the rest). Then find where Assets_Manager prints the inherited inline CSS so the --wp--preset--color--ti-* overrides can move there. Done looks like literal hex values in the palette, Neve-migrated sites still showing Neve's colours, and no wp.components.Theme warnings in the Site Editor console with SCRIPT_DEBUG on.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
Description

The theme's colour palette is defined as CSS variables, which the Site Editor's own colour handling can't read. Every time the Site Editor opens, the browser console shows three warnings:

wp.components.Theme: "var(--nv-text-color, #202020)" is not a valid color value for the 'accent' prop.
wp.components.Theme: "var(--nv-site-bg, #FFFFFF)" is not a valid color value for the 'background' prop.
wp.components.Theme: The background color ("var(--nv-site-bg, #FFFFFF)") does not have sufficient contrast against the accent color ("var(--nv-text-color, #202020)").

Every entry of theme.json settings.color.palette is a var(--nv-…, #hex) value, so that a site coming from Neve inherits Neve's colours (ti-bg is var(--nv-site-bg, #FFFFFF), ti-fg is var(--nv-text-color, #202020), and so on). The Site Editor passes the palette's background and foreground to wp.components.Theme, which expects literal colours. So it can't compute the canvas UI's colours or the contrast check from them.

Step-by-step reproduction instructions
  1. With Eduacademy 1.0.1 active and SCRIPT_DEBUG on, go to Appearance → Editor.
  2. Open the browser console.

Expected: no warnings from the theme's palette.
Actual: the three wp.components.Theme warnings above, on every Site Editor load, and on every template or part opened in it.

Screenshots, screen recording, code snippet or Help Scout ticket

Possible fix: keep literal hex values in theme.json's palette, and apply the Neve overrides through the inherited inline CSS that Assets_Manager already prints (overriding the --wp--preset--color--ti-* variables there). The palette entries would then be real colours, while a site coming from Neve still gets Neve's colours.

Found while adding Eduacademy to the WordPress compatibility checks (Codeinwp/qa-compatibility#168). Seen on WordPress 7.0.9, 7.1-RC1 and 7.1.5 alike.

Environment info

Eduacademy 1.0.1 (built from the v1.0.1 tag), WordPress 7.0.9 / 7.1-RC1 / 7.1.5, PHP 8.3, SCRIPT_DEBUG on, Chromium.

Is the issue you are reporting a regression

No

Lingua principale
PHP
Stelle
0
Fork
0
Merge medio
22h 12m
PR unite (30g)
6

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Codeinwp/eduacademy

Tutte le issue di Codeinwp/eduacademy

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.