Formula over a sum/gauge select and a histogram select gives 0 or null when the chart has a group-by

Abierto
#3,501 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
65/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
clickhouse, typescript

Línea de trabajo

Start with the multi-series rendering logic in packages/common-utils/src/core/renderChartConfig.ts, especially the group-value padding and pivot behavior cited in the issue. Then read renderChartConfig.int.test.ts and add an integration case using the provided sum, histogram, formula, and group-by setup. Done means the formula is correct per group, or the editor/API rejects this unsupported combination rather than returning misleading 0s.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

external

What happened?

A chart has two selects: A, a Sum metric (aggFn: sum), and B, a Histogram metric (aggFn: count). It has the formula A / B, group-by ServiceName and 5-minute granularity. A and B never end up on the same row, so the formula never gets both operands:

{"sum(repro.requests)": 660,  "count(repro.latency)": null, "ratio": null, "ServiceName": "a",  "group": []}
{"sum(repro.requests)": null, "count(repro.latency)": 40,   "ratio": 0,    "ServiceName": null, "group": ["a"]}

The query returns ratio 0 on the histogram rows (a missing A counts as 0) and null on the sum rows, so a chart draws 0s. Without the group-by, the same formula is correct: 660 / 40 = 16.5, and 300 / 10 = 30.

This looks deliberate in the multi-series rendering. Histogram branches pack the group values into group and pad the scalar group columns with NULL. Scalar branches pad group with [] "so scalar rows never share a grouping key with histogram rows":

The pivot then groups by the scalar columns and group, so A and B for service a land on different rows.

Expected: A and B for the same group value on one row, and the formula per group. If a sum/gauge and a histogram select can't share a group-by, the editor and the API should reject the formula, not show a series of 0s.

Use case: per-service ratios that mix a counter with a histogram's count, for example errors per request when requests are only recorded as a latency histogram.

Steps to reproduce

Reproduces on play.hyperdx.io? Didn't try.

An integration test in the style of renderChartConfig.int.test.ts, on main (2bfc630):

  1. Insert a cumulative monotonic sum repro.requests and a cumulative histogram repro.latency, both with ServiceName a and b, one point a minute for 6 minutes.
  2. renderChartConfig with select: [{ aggFn: 'sum', metricType: 'sum', metricName: 'repro.requests' }, { aggFn: 'count', metricType: 'histogram', metricName: 'repro.latency' }], formulas: [{ expression: 'A / B', alias: 'ratio' }], groupBy: 'ServiceName', granularity: '5 minute'.
  3. Every row has either A or B null; ratio is null or 0.
  4. Remove groupBy. ratio is correct.

How are you running HyperDX?

Helm (ClickStack chart 2.1.0) with the hyperdx:2-nightly image (2.42.0 plus the Node bump from #3456), our own ClickHouse 26.2.5.45. Reproduced on main 2bfc630.

Where does it show up?

Dashboard tiles with formulas. We hit it through the MCP dashboard tools; the UI renders through the same renderChartConfig.

Debug info

N/A.

Logs

None; no error is raised.


Written with help from an AI assistant (Claude Code). The behaviour comes from our own deployment and an integration test on main.

Lenguaje dominante
TypeScript
Estrellas
10.1k
Forks
527
Merge medio
1 d 20 h
PR fusionados (30 d)
186

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ClickHouse/ClickStack

Todos los issues de ClickHouse/ClickStack

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.