Formula over a sum/gauge select and a histogram select gives 0 or null when the chart has a group-by

未关闭
#3,501 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
65/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
clickhouse, typescript
领域
observability

调研方向

Start with the multi-series rendering logic in packages/common-utils/src/core/renderChartConfig.ts, especially the group-value padding and pivot behavior cited in the issue. Then read renderChartConfig.int.test.ts and add an integration case using the provided sum, histogram, formula, and group-by setup. Done means the formula is correct per group, or the editor/API rejects this unsupported combination rather than returning misleading 0s.

由索引模型根据 Issue 内容生成。

描述

external

What happened?

A chart has two selects: A, a Sum metric (aggFn: sum), and B, a Histogram metric (aggFn: count). It has the formula A / B, group-by ServiceName and 5-minute granularity. A and B never end up on the same row, so the formula never gets both operands:

{"sum(repro.requests)": 660,  "count(repro.latency)": null, "ratio": null, "ServiceName": "a",  "group": []}
{"sum(repro.requests)": null, "count(repro.latency)": 40,   "ratio": 0,    "ServiceName": null, "group": ["a"]}

The query returns ratio 0 on the histogram rows (a missing A counts as 0) and null on the sum rows, so a chart draws 0s. Without the group-by, the same formula is correct: 660 / 40 = 16.5, and 300 / 10 = 30.

This looks deliberate in the multi-series rendering. Histogram branches pack the group values into group and pad the scalar group columns with NULL. Scalar branches pad group with [] "so scalar rows never share a grouping key with histogram rows":

The pivot then groups by the scalar columns and group, so A and B for service a land on different rows.

Expected: A and B for the same group value on one row, and the formula per group. If a sum/gauge and a histogram select can't share a group-by, the editor and the API should reject the formula, not show a series of 0s.

Use case: per-service ratios that mix a counter with a histogram's count, for example errors per request when requests are only recorded as a latency histogram.

Steps to reproduce

Reproduces on play.hyperdx.io? Didn't try.

An integration test in the style of renderChartConfig.int.test.ts, on main (2bfc630):

  1. Insert a cumulative monotonic sum repro.requests and a cumulative histogram repro.latency, both with ServiceName a and b, one point a minute for 6 minutes.
  2. renderChartConfig with select: [{ aggFn: 'sum', metricType: 'sum', metricName: 'repro.requests' }, { aggFn: 'count', metricType: 'histogram', metricName: 'repro.latency' }], formulas: [{ expression: 'A / B', alias: 'ratio' }], groupBy: 'ServiceName', granularity: '5 minute'.
  3. Every row has either A or B null; ratio is null or 0.
  4. Remove groupBy. ratio is correct.

How are you running HyperDX?

Helm (ClickStack chart 2.1.0) with the hyperdx:2-nightly image (2.42.0 plus the Node bump from #3456), our own ClickHouse 26.2.5.45. Reproduced on main 2bfc630.

Where does it show up?

Dashboard tiles with formulas. We hit it through the MCP dashboard tools; the UI renders through the same renderChartConfig.

Debug info

N/A.

Logs

None; no error is raised.


Written with help from an AI assistant (Claude Code). The behaviour comes from our own deployment and an integration test on main.

主要语言
TypeScript
星标
10.1k
派生
527
平均合并
1 天 20 小时
30 天内合并 PR
186

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

ClickHouse/ClickStack 的其他 Issue

查看 ClickHouse/ClickStack 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。