E2E coverage for the trace search RED metrics view

Abierto
#3,176 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
70/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
clickhouse, react, typescript

Línea de trabajo

Start by examining the existing e2e test for the histogram in packages/app/tests/e2e/features/search/search.spec.ts. The fixtures already seed an E2E Traces source. First, add data-testid props to the RED tiles in the trace search view, likely in the component that renders ChartCard. Then write a new spec that uses searchPage.selectSource(DEFAULT_TRACES_SOURCE_NAME) to switch to the trace source and verify the RED tiles appear. Test the Errors tile toggle, the RED/Heatmap switch persistence in the URL, and that clicking a status series filters results. Run the e2e tests to confirm the new view works as expected.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Context

PR #2826 replaces the single count histogram on trace search results with RED metrics (Throughput, Errors, Duration) and adds a RED/Heatmap switch. The aggregation builders and the chart color pipeline are unit tested, but nothing drives the view end to end.

The existing search e2e specs cover the histogram on a Logs source (Histogram drag-to-zoom preserves custom SELECT columns in packages/app/tests/e2e/features/search/search.spec.ts), and that path is unchanged: the RED view only renders for trace sources. So the new view currently has no e2e coverage.

What to cover

The e2e fixtures already seed an E2E Traces source and several specs switch to it via searchPage.selectSource(DEFAULT_TRACES_SOURCE_NAME), so this should fit the existing page-object pattern:

  • Selecting a trace source renders the three RED tiles; a Logs source still renders the single histogram.
  • The Errors tile switches between Rate and Volume.
  • The RED/Heatmap switch swaps the area for the duration heatmap, and the mode survives a reload (it is stored in the URL as traceChartMode).
  • Clicking a status series on the Errors volume chart filters the results.

Notes

The RED tiles render through ChartCard, which already accepts a data-testid, but the trace search tiles do not pass one today. Adding stable test ids for the three tiles is probably the first step so the spec does not have to match on visible title text.

Lenguaje dominante
TypeScript
Estrellas
10.1k
Forks
527
Merge medio
1 d 20 h
PR fusionados (30 d)
186

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ClickHouse/ClickStack

Todos los issues de ClickHouse/ClickStack

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.