E2E coverage for the trace search RED metrics view

Ouverte
#3,176 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
70/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
clickhouse, react, typescript

Piste de recherche

Start by examining the existing e2e test for the histogram in packages/app/tests/e2e/features/search/search.spec.ts. The fixtures already seed an E2E Traces source. First, add data-testid props to the RED tiles in the trace search view, likely in the component that renders ChartCard. Then write a new spec that uses searchPage.selectSource(DEFAULT_TRACES_SOURCE_NAME) to switch to the trace source and verify the RED tiles appear. Test the Errors tile toggle, the RED/Heatmap switch persistence in the URL, and that clicking a status series filters results. Run the e2e tests to confirm the new view works as expected.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Context

PR #2826 replaces the single count histogram on trace search results with RED metrics (Throughput, Errors, Duration) and adds a RED/Heatmap switch. The aggregation builders and the chart color pipeline are unit tested, but nothing drives the view end to end.

The existing search e2e specs cover the histogram on a Logs source (Histogram drag-to-zoom preserves custom SELECT columns in packages/app/tests/e2e/features/search/search.spec.ts), and that path is unchanged: the RED view only renders for trace sources. So the new view currently has no e2e coverage.

What to cover

The e2e fixtures already seed an E2E Traces source and several specs switch to it via searchPage.selectSource(DEFAULT_TRACES_SOURCE_NAME), so this should fit the existing page-object pattern:

  • Selecting a trace source renders the three RED tiles; a Logs source still renders the single histogram.
  • The Errors tile switches between Rate and Volume.
  • The RED/Heatmap switch swaps the area for the duration heatmap, and the mode survives a reload (it is stored in the URL as traceChartMode).
  • Clicking a status series on the Errors volume chart filters the results.

Notes

The RED tiles render through ChartCard, which already accepts a data-testid, but the trace search tiles do not pass one today. Adding stable test ids for the three tiles is probably the first step so the spec does not have to match on visible title text.

Langage dominant
TypeScript
Étoiles
10.1k
Forks
527
Merge moyen
1 j 20 h
PR mergées (30 j)
186

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de ClickHouse/ClickStack

Toutes les issues de ClickHouse/ClickStack

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.