Reduce EntranceListener work and per-player state

Abierto
  • ¿Algo no está bien?
#78 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java
Área
backend

Línea de trabajo

Find EntranceListener and its movement handling, playerStoreStatus, and the shared attributes map; then read the existing listener tests and event registration. Check how PlayerMoveEvent exposes block changes and how quit events are handled. Done means head-only movement triggers no store lookups, quit removes UUID state, and messages for two players use their own stores, with tests covering all three.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement java

Problem

EntranceListener does more work than it needs to on every player movement:

  • It runs on every PlayerMoveEvent, including when a player only turns their head, and checks every store each time.
  • playerStoreStatus is keyed by Player and never cleared, so entries build up as players leave.
  • It shares one attributes map across all players, so a custom goodbye message using {store} can name another player's store.

Scope

  • Return early unless the player moved to a different block.
  • Key by UUID and remove entries on PlayerQuitEvent.
  • Keep the store for each player, so messages use the right one.

Done when

  • Turning in place does no store lookups.
  • Tests cover head-only movement, quitting, and two players in different stores.
Lenguaje dominante
Java
Estrellas
1
Forks
0
Merge medio
2 h 35 min
PR fusionados (30 d)
14

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de BrendonButler/Shops

Todos los issues de BrendonButler/Shops

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.