WebSocketConnect in reconnect case

Open
#84 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, javascript
Domain
networking

Research direction

Inspect the jslib WebSocketConnect method and its onclose handler, where instance.ws is deleted. Reproduce reconnecting after a socket is closed, then verify that the reconnect path no longer treats an undefined instance.ws as an existing socket.

Written by the indexing model from the issue text.

Description

Hi @endel
Thank you for your great work
I have tryed to resolve issue with reconnect socket that was close before
In jslib there is method WebSocketConnect
and in this method we have condition
if (instance.ws !== null) {...}
but if we called close socket before, we deleted instance.ws

instance.ws.onclose = function (ev) {
     if (webSocketState.onClose)
         Module.dynCall_vii(webSocketState.onClose, instanceId, ev.code);
     delete instance.ws;
};

then I try to connect web socket again and instance.ws !== null will be always true
in this case "instance.ws" will be 'undefined', so the better condition will be '!=' not '!=='
Does it make sense?
Thank you

Dominant language
C#
Stars
1.7k
Forks
206
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from endel/NativeWebSocket

All issues in endel/NativeWebSocket

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.