Websockets OnClose doesn't contain the close message

Open
#50 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
networking

Research direction

Start by locating the WebSocket OnClose delegate and the close-handling entry point in NativeWebSocket. Check how the close reason is currently emitted and identify where the close message is available. Done means OnClose exposes both the reason enum and message, with the existing behavior preserved where no message is provided.

Written by the indexing model from the issue text.

Description

bug help wanted

When a websocket closes, they contain a reason for close, additionally they contain a message. Currently this libraries OnClose delegate just emits the reason enum and not a message too.

Dominant language
C#
Stars
1.7k
Forks
206
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from endel/NativeWebSocket

All issues in endel/NativeWebSocket

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.