Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Ability to determine if a message is binary or text

Open
#26 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
28/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
networking

Research direction

Start by locating the OnMessage(byte[] bytes) API and the library's WebSocketMessageType handling across its supported clients. Review the two proposed API shapes and existing client behavior before choosing an approach; done means clients can reliably distinguish text messages from binary messages.

Written by the indexing model from the issue text.

Description

Currently, the API only has OnMessage(byte[] bytes), but this doesn't allow us to determine if the message was encoded as binary or text. This data is known to the library via WebSocketMessageType, so I suggest this be exposed to clients as well.

Some options:

  1. Add a second parameter, like: OnMessage(byte[] bytes, WebSocketMessageType messageType)
  2. Create separate events, like: OnMessageText(string data) and OnMessageBinary(byte[] bytes).

I'd be happy to submit a PR implementing either approach, let me know what you think!

Thanks again for this great library.

Dominant language
C#
Stars
1.7k
Forks
206
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from endel/NativeWebSocket

All issues in endel/NativeWebSocket

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.