cli: sign-in requests send Node's default User-Agent

Open Beginner friendly
#628 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, node.js

Research direction

Read packages/pivotkit-cli/src/sign-in.js and compare its send() calls with the CLI REST calls to find the existing user-agent value. Pass that same value to the login, token and logout sign-in requests, then update the network table in docs/security.md. Done when the issuer receives the CLI user agent and the documentation reflects it.

Written by the indexing model from the issue text.

Description

area:cli

pivotkit login, token and logout call send() in packages/pivotkit-cli/src/sign-in.js without a user-agent header. So the issuer sees Node's default node, while the CLI's REST calls send pivotkit-cli/<version>.

Fix: pass the same user agent into the sign-in calls, then update the table in docs/security.md#network.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 10m
Merged PRs (30d)
267

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.