react: plainer words in the filter level, and a hint when a filter keeps every value

Open Beginner friendly
#595 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, react

Research direction

Find the filter level opened from “+ Add” for Filters and the Filter level on a field, then locate the “Text condition” label and the state where every value is selected. Read the related components and tests first; update the wording and add the hint in both locations. Done when both filter levels use clearer wording and explain that selecting every value filters nothing, with behavior unchanged.

Written by the indexing model from the issue text.

Description

area:react enhancement

A role test of the "+ Add" menu turned up two rough spots in the filter level:

  • "Text condition" is jargon. A user without a technical background does not know what it means. The wording should say what the control does.
  • No hint when every value is ticked. If you add a filter and apply it with every value still ticked, the filter is accepted, but it filters nothing. A short hint would help, for example "All values are selected, so nothing is filtered yet."

Both are in the filter level that "+ Add" opens for Filters, and in a field's own Filter level. They are wording and hint changes, so the behaviour stays the same.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 10m
Merged PRs (30d)
267

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.