react: plainer words in the filter level, and a hint when a filter keeps every value
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, react
- Domain
- data-visualization, frontend
Research direction
Find the filter level opened from “+ Add” for Filters and the Filter level on a field, then locate the “Text condition” label and the state where every value is selected. Read the related components and tests first; update the wording and add the hint in both locations. Done when both filter levels use clearer wording and explain that selecting every value filters nothing, with behavior unchanged.
Written by the indexing model from the issue text.
Description
A role test of the "+ Add" menu turned up two rough spots in the filter level:
- "Text condition" is jargon. A user without a technical background does not know what it means. The wording should say what the control does.
- No hint when every value is ticked. If you add a filter and apply it with every value still ticked, the filter is accepted, but it filters nothing. A short hint would help, for example "All values are selected, so nothing is filtered yet."
Both are in the filter level that "+ Add" opens for Filters, and in a field's own Filter level. They are wording and hint changes, so the behaviour stays the same.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 3h 10m
- Merged PRs (30d)
- 267
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eizedev/pivotkit
-
area:mcp
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:cli
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:tests
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area:tests
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
All issues in eizedev/pivotkit
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
-
Extended search drops any query term that contains a line breakPossibly taken @goranai claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day