check-config: groupProfiles order warning compares fields lists, not effective levels

Open
#440 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
backend, cli

Research direction

Find the check-config logic that checks groupProfiles order and the related tests. Read how source policies are merged with profiles, then compare effective levels per source. Add the finance/staff example as a regression test; done means it no longer reports an order warning when both profiles effectively show the fields.

Written by the indexing model from the issue text.

Description

area:server bug

check-config reports a false order warning for groupProfiles. It fires when a later profile lists only fields at a level that the earlier profile already gets from the source policy.

Example:

  • finance: {fields: {Sales: show, amount: show, Customer: show}}
  • staff: {fields: {Region: show, Product: show}}

check-config warns "entry 2 (staff) shows fields that entry 1 (finance) holds back". But the source policy already shows Region and Product, so the effective level is show for both profiles.

Not affected: runtime behaviour. The profile choice is correct; only the warning is wrong.

Fix: compare the effective levels per source (source policy merged with the profile), not the profiles' fields lists. Add the example as a test.

Found while setting up a live test stack with three test users.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 21m
Merged PRs (30d)
250

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.