check-config: groupProfiles order warning compares fields lists, not effective levels
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
Research direction
Find the check-config logic that checks groupProfiles order and the related tests. Read how source policies are merged with profiles, then compare effective levels per source. Add the finance/staff example as a regression test; done means it no longer reports an order warning when both profiles effectively show the fields.
Written by the indexing model from the issue text.
Description
check-config reports a false order warning for groupProfiles. It fires when a later profile lists only fields at a level that the earlier profile already gets from the source policy.
Example:
- finance:
{fields: {Sales: show, amount: show, Customer: show}} - staff:
{fields: {Region: show, Product: show}}
check-config warns "entry 2 (staff) shows fields that entry 1 (finance) holds back". But the source policy already shows Region and Product, so the effective level is show for both profiles.
Not affected: runtime behaviour. The profile choice is correct; only the warning is wrong.
Fix: compare the effective levels per source (source policy merged with the profile), not the profiles' fields lists. Add the example as a test.
Found while setting up a live test stack with three test users.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 3h 21m
- Merged PRs (30d)
- 250
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eizedev/pivotkit
-
accessibility area:react bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
area:tests
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area:cli bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
area:cli enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:react enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in eizedev/pivotkit
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
mattabate/life-distributable#231 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
sfbrigade/pocket-gardens#60 ·
Maintainers usually reply within 5 days
-
The print preview leaves writing space short by the margins of hidden headers, footers and solutionsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PreTeXtBook/pretext#3329 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
devarshishimpi/codra#178 ·
Maintainers usually reply within 1 day