ECharts SSR: quotes in style values are not escaped

Open
#211 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
56/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
javascript, react

Research direction

Start by inspecting the current ECharts SVG renderer source and reproduce the issue with a fontFamily value containing quotes, such as "Segoe UI", sans-serif. The issue points to packages/pivotkit-report/src/tokens.js as the workaround and says cleanSvg rejects the resulting SVG; confirm whether ECharts still leaves quotes unescaped. If so, prepare an upstream issue proposal for the maintainer to approve.

Written by the indexing model from the issue text.

Description

area:report bug idea

ECharts 6.1.0 SSR (SVG renderer) does not escape quotes in style attribute values: a fontFamily such as "Segoe UI", sans-serif breaks the SVG. Workaround in packages/pivotkit-report/src/tokens.js (font names without quotes), and cleanSvg refuses such an SVG. To do: check the current ECharts source and, if still present, propose an upstream issue (text needs my approval).

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 21m
Merged PRs (30d)
250

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.