ECharts SSR: quotes in style values are not escaped
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 56/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, react
- Domain
- data-visualization
Research direction
Start by inspecting the current ECharts SVG renderer source and reproduce the issue with a fontFamily value containing quotes, such as "Segoe UI", sans-serif. The issue points to packages/pivotkit-report/src/tokens.js as the workaround and says cleanSvg rejects the resulting SVG; confirm whether ECharts still leaves quotes unescaped. If so, prepare an upstream issue proposal for the maintainer to approve.
Written by the indexing model from the issue text.
Description
ECharts 6.1.0 SSR (SVG renderer) does not escape quotes in style attribute values: a fontFamily such as "Segoe UI", sans-serif breaks the SVG. Workaround in packages/pivotkit-report/src/tokens.js (font names without quotes), and cleanSvg refuses such an SVG. To do: check the current ECharts source and, if still present, propose an upstream issue (text needs my approval).
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 3h 21m
- Merged PRs (30d)
- 250
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eizedev/pivotkit
-
accessibility area:react bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
area:tests
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area:cli bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
area:cli enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:react enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in eizedev/pivotkit
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
mattabate/life-distributable#231 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
sfbrigade/pocket-gardens#60 ·
Maintainers usually reply within 5 days
-
The print preview leaves writing space short by the margins of hidden headers, footers and solutionsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PreTeXtBook/pretext#3329 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
devarshishimpi/codra#178 ·
Maintainers usually reply within 1 day