Print frame: check removal in real Safari

Open Beginner friendly
#210 8 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
69/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, playwright, react
Domain
frontend, testing

Research direction

Start with packages/pivotkit-react/src/print-frame.js and trace how the page's afterprint handler removes the frame. Check printing in Safari on macOS and iOS, since Playwright WebKit is the only verification mentioned. Done means confirming whether Safari fires the page's afterprint event when the frame prints and reporting whether the hidden frame remains.

Written by the indexing model from the issue text.

Description

area:react area:tests bug

packages/pivotkit-react/src/print-frame.js: WebKit runs no listener in a frame sandboxed without scripts, so the frame is removed by the page's own afterprint. Not checked in real Safari (only Playwright WebKit): if Safari does not fire the page's afterprint when a frame prints, the hidden 1 px frame stays until the next print. Check in Safari on macOS and iOS.

Dominant language
JavaScript
Stars
1
Forks
1
Avg merge
3h 21m
Merged PRs (30d)
250

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from eizedev/pivotkit

All issues in eizedev/pivotkit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.