Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

[Bug]: API requests send incorrect TabId in pop-ups

Open
  • Is something wrong?
#7,127 6 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, javascript
Domain
api, backend

Research direction

Start by locating dnnModal.show and the code that assembles API request headers, then reproduce the issue using the Resource Manager steps in the report. Trace how the pop-up page's TabId is obtained and passed into those headers. Done means requests from pop-up modules send the pop-up page's TabId and Resource Manager loads as expected.

Written by the indexing model from the issue text.

Description

Type: Bug
Is there an existing issue for this?
  • I have searched the existing issues
What happened?

When opening another page in a pop-up via dnnModal.show, requests from modules on that page get the parent page TabId put in the request headers. This causes problems for APIs that use that, as that module may not exist on the parent page. The TabId of the page open in the pop-up should be sent instead.

Steps to reproduce?
  1. Enable pop-ups (It's disabled by default on 10.X.X)
  2. Add the Resource Manager module to a page
  3. On another page, add a module that opens the first page via dnnModal.show. An example of this would be an HTML module with this HTML:<p><a href="/Test" onclick="return dnnModal.show('/Test?popUp=true',true,550,950,false)">Test Pop-up</a></p>
  4. Open the pop-up
Current Behavior

The incorrect TabId is sent in the request headers; parent page instead of pop-up page. In the example given above, Resource Manager is unable to get its settings and folder information. It may also trigger browser alerts related to the info the API calls were supposed to get.

Expected Behavior

API calls from modules on the pop-up page should have the correct TabId in the request headers. In the example above, Resource Manager should load as expected.

Relevant log output
{"Message":"Specified module instance does not exist."}
Anything else?

No response

Affected Versions

10.2.3 (latest release)

What browsers are you seeing the problem on?

Chrome

Code of Conduct
  • I agree to follow this project's Code of Conduct
Dominant language
C#
Stars
1.1k
Forks
791
Avg merge
2d 2h
Merged PRs (30d)
24

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dnnsoftware/Dnn.Platform

All issues in dnnsoftware/Dnn.Platform

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.